T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cranelift-fuzzgen-verify is redundant with cranelift-fuzzgen (#4411)

Browse Source 
The compile step that cranelift-fuzzgen does also triggers IR
verification. So all bugs that cranelift-fuzzgen-verify could catch are
also caught by cranelift-fuzzgen. Removing redundant fuzzers lets us
spend limited fuzz-testing CPU time budgets better.
This commit is contained in:
Jamey Sharp
2022-07-07 15:05:23 -07:00
committed by GitHub
parent 601e8f3094
commit ff8c26b7ef
3 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fuzz/Cargo.toml
View File

@@ -96,12 +96,6 @@ doc = false
# test = false # test = false
# doc = false # doc = false
# [[bin]]
# name = "cranelift-fuzzgen-verify"
# path = "fuzz_targets/cranelift-fuzzgen-verify.rs"
# test = false
# doc = false
[[bin]] [[bin]]
name = "instantiate-many" name = "instantiate-many"
path = "fuzz_targets/instantiate-many.rs" path = "fuzz_targets/instantiate-many.rs"

2
fuzz/README.md
View File

@@ -30,8 +30,6 @@ At the time of writing, we have the following fuzz targets:
* `cranelift-fuzzgen`: Generate a Cranelift function and check that it returns * `cranelift-fuzzgen`: Generate a Cranelift function and check that it returns
the same results when compiled to the host and when using the Cranelift the same results when compiled to the host and when using the Cranelift
interpreter; only a subset of Cranelift IR is currently supported. interpreter; only a subset of Cranelift IR is currently supported.
* `cranelift-fuzzgen-verify`: Stress the Cranelift IR verifier by generating a
Cranelift function and checking that it is indeed a valid function.
* `differential`: Generate a Wasm module and check that Wasmtime returns * `differential`: Generate a Wasm module and check that Wasmtime returns
the same results when run with two different configurations. the same results when run with two different configurations.
* `differential_spec`: Generate a Wasm module and check that Wasmtime returns * `differential_spec`: Generate a Wasm module and check that Wasmtime returns

11
fuzz/fuzz_targets/cranelift-fuzzgen-verify.rs
View File

@@ -1,11 +0,0 @@
#![no_main]
use libfuzzer_sys::fuzz_target;
use cranelift_codegen::{settings, verify_function};
use cranelift_fuzzgen::TestCase;
fuzz_target!(|testcase: TestCase| {
let flags = settings::Flags::new(settings::builder());
verify_function(&testcase.func, &flags).unwrap();
});