From ff8c26b7efbc66000c124c0c49524bd79e65014f Mon Sep 17 00:00:00 2001 From: Jamey Sharp Date: Thu, 7 Jul 2022 15:05:23 -0700 Subject: [PATCH] cranelift-fuzzgen-verify is redundant with cranelift-fuzzgen (#4411) The compile step that cranelift-fuzzgen does also triggers IR verification. So all bugs that cranelift-fuzzgen-verify could catch are also caught by cranelift-fuzzgen. Removing redundant fuzzers lets us spend limited fuzz-testing CPU time budgets better. --- fuzz/Cargo.toml | 6 ------ fuzz/README.md | 2 -- fuzz/fuzz_targets/cranelift-fuzzgen-verify.rs | 11 ----------- 3 files changed, 19 deletions(-) delete mode 100644 fuzz/fuzz_targets/cranelift-fuzzgen-verify.rs diff --git a/fuzz/Cargo.toml b/fuzz/Cargo.toml index a55a55ae2f..90d851e6e5 100644 --- a/fuzz/Cargo.toml +++ b/fuzz/Cargo.toml @@ -96,12 +96,6 @@ doc = false # test = false # doc = false -# [[bin]] -# name = "cranelift-fuzzgen-verify" -# path = "fuzz_targets/cranelift-fuzzgen-verify.rs" -# test = false -# doc = false - [[bin]] name = "instantiate-many" path = "fuzz_targets/instantiate-many.rs" diff --git a/fuzz/README.md b/fuzz/README.md index b2e51170c3..47a5f6f9a2 100644 --- a/fuzz/README.md +++ b/fuzz/README.md @@ -30,8 +30,6 @@ At the time of writing, we have the following fuzz targets: * `cranelift-fuzzgen`: Generate a Cranelift function and check that it returns the same results when compiled to the host and when using the Cranelift interpreter; only a subset of Cranelift IR is currently supported. -* `cranelift-fuzzgen-verify`: Stress the Cranelift IR verifier by generating a - Cranelift function and checking that it is indeed a valid function. * `differential`: Generate a Wasm module and check that Wasmtime returns the same results when run with two different configurations. * `differential_spec`: Generate a Wasm module and check that Wasmtime returns diff --git a/fuzz/fuzz_targets/cranelift-fuzzgen-verify.rs b/fuzz/fuzz_targets/cranelift-fuzzgen-verify.rs deleted file mode 100644 index 55056bf18c..0000000000 --- a/fuzz/fuzz_targets/cranelift-fuzzgen-verify.rs +++ /dev/null @@ -1,11 +0,0 @@ -#![no_main] - -use libfuzzer_sys::fuzz_target; - -use cranelift_codegen::{settings, verify_function}; -use cranelift_fuzzgen::TestCase; - -fuzz_target!(|testcase: TestCase| { - let flags = settings::Flags::new(settings::builder()); - verify_function(&testcase.func, &flags).unwrap(); -});