T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify comments about Conventional SSA form.

Browse Source 
Captialize "Conventional" so that it's clear that "Conventional SSA"
is a specific concept being referenced.
This commit is contained in:
Dan Gohman
2018-03-12 10:28:39 -07:00
parent 30f8daa9d6
commit f04e02c0a1
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/cretonne/src/regalloc/coalescing.rs
View File

@@ -1,9 +1,9 @@
//! Constructing conventional SSA form. //! Constructing Conventional SSA form.
//! //!
//! Conventional SSA form is a subset of SSA form where any (transitively) phi-related values do //! Conventional SSA (CSSA) form is a subset of SSA form where any (transitively) phi-related
//! not interfere. We construct CSSA by building virtual registers that are as large as possible //! values do not interfere. We construct CSSA by building virtual registers that are as large as
//! and inserting copies where necessary such that all argument values passed to an EBB parameter //! possible and inserting copies where necessary such that all argument values passed to an EBB
//! will belong to the same virtual register as the EBB parameter value itself. //! parameter will belong to the same virtual register as the EBB parameter value itself.
use cursor::{Cursor, EncCursor}; use cursor::{Cursor, EncCursor};
use dbg::DisplayList; use dbg::DisplayList;
@@ -103,7 +103,7 @@ impl Coalescing {
self.backedges.clear(); self.backedges.clear();
} }
/// Convert `func` to conventional SSA form and build virtual registers in the process. /// Convert `func` to Conventional SSA form and build virtual registers in the process.
pub fn conventional_ssa( pub fn conventional_ssa(
&mut self, &mut self,
isa: &TargetIsa, isa: &TargetIsa,

2
lib/cretonne/src/regalloc/coloring.rs
View File

@@ -23,7 +23,7 @@
//! operands are allowed to read spilled values, but each such instance must be counted as using //! operands are allowed to read spilled values, but each such instance must be counted as using
//! a register. //! a register.
//! //!
//! 5. The code must be in conventional SSA form. Among other things, this means that values passed //! 5. The code must be in Conventional SSA form. Among other things, this means that values passed
//! as arguments when branching to an EBB must belong to the same virtual register as the //! as arguments when branching to an EBB must belong to the same virtual register as the
//! corresponding EBB argument value. //! corresponding EBB argument value.
//! //!

2
lib/cretonne/src/regalloc/context.rs
View File

@@ -90,7 +90,7 @@ impl Context {
verify_liveness(isa, func, cfg, &self.liveness)?; verify_liveness(isa, func, cfg, &self.liveness)?;
} }
// Pass: Coalesce and create conventional SSA form. // Pass: Coalesce and create Conventional SSA form.
self.coalescing.conventional_ssa( self.coalescing.conventional_ssa(
isa, isa,
func, func,