Assert all InstructionGroups are closed in TargetIsa.__init__(); Close x86 group

lib/cretonne/meta/cdsl/isa.py

@@ -5,6 +5,7 @@ from .predicates import And
 from .registers import RegClass, Register, Stack
 from .ast import Apply
 from .types import ValueType
+from .instructions import InstructionGroup
 
 # The typing module is only required by mypy, and we don't use these imports
 # outside type comments.
@@ -47,6 +48,10 @@ class TargetISA(object):
         self.regclasses = list()  # type: List[RegClass]
         self.legalize_codes = OrderedDict()  # type: OrderedDict[XFormGroup, int]  # noqa
 
+        assert InstructionGroup._current is None,\
+            "InstructionGroup {} is still open!"\
+            .format(InstructionGroup._current.name)
+
     def __str__(self):
         # type: () -> str
         return self.name

lib/cretonne/meta/isa/intel/instructions.py

@@ -43,3 +43,5 @@ sdivmodx = Instruction(
         Return both quotient and remainder.
         """,
         ins=(nlo, nhi, d), outs=(q, r), can_trap=True)
+
+GROUP.close()