T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove should_panic assertions from wast spec tests (#1590)

Browse Source 
This commit removes the `should_panic` function now that all wasm spec
tests are passing on arm64 (yay!). The remaining case, SIMD, has been
folded into `#[ignore]`. This should prevent tons of panics from showing
up in the logs while on CI because it's likely going to be some time
before SIMD for aarch64 is tackled.
This commit is contained in:
Alex Crichton
2020-04-24 15:08:40 -05:00
committed by GitHub
parent 74eda8090c
commit b1ceea3af9
1 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
build.rs
View File

@@ -154,9 +154,6 @@ fn write_testsuite_tests(
if ignore(testsuite, &testname, strategy) {
writeln!(out, "#[ignore]")?;
}
if should_panic(testsuite, &testname) {
writeln!(out, "#[should_panic]")?;
}
writeln!(out, "fn r#{}() {{", &testname)?;
writeln!(
out,
@@ -183,6 +180,10 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool {
_ => (),
},
"Cranelift" => match (testsuite, testname) {
// All simd tests are known to fail on aarch64 for now, it's going
// to be a big chunk of work to implement them all there!
("simd", _) if target.contains("aarch64") => return true,
("simd", "simd_bit_shift") => return true, // FIXME Unsupported feature: proposed SIMD operator I8x16Shl
("simd", "simd_conversions") => return true, // FIXME Unsupported feature: proposed SIMD operator I16x8NarrowI32x4S
("simd", "simd_f32x4") => return true, // FIXME expected V128(F32x4([CanonicalNan, CanonicalNan, Value(Float32 { bits: 0 }), Value(Float32 { bits: 0 })])), got V128(18428729675200069632)
@@ -215,18 +216,3 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool {
false
}
/// Determine whether to add a should_panic attribute. These tests currently
/// panic because of unfinished backend implementation work; we will remove them
/// from this list as we finish the implementation
fn should_panic(testsuite: &str, testname: &str) -> bool {
let target = env::var("TARGET").unwrap();
if !target.contains("aarch64") {
return false;
}
match (testsuite, testname) {
// FIXME(#1521)
("simd", _) => true,
_ => false,
}
}