T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Turn off memfd by default, at least for this upcoming release. (#3774)

Browse Source 
Since memfd support just landed, and has had only ~0.5 weeks to bake
with fuzzing, we want to make release 0.34.0 of Wasmtime without it
enabled by default. This PR disables memfd by default; it can be enabled
by specifying the `memfd` feature for the `wasmtime` crate, or when
building the commandline binary.

We plan to explicitly add memfd-enabled fuzzing targets, let that go for
a while, then probably re-enable memfd in the subsequent release if no
issues come up.
This commit is contained in:
Chris Fallin
2022-02-07 13:44:53 -08:00
committed by GitHub
parent ff622667f7
commit 88b53b12aa
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Cargo.toml
View File

@@ -94,7 +94,6 @@ default = [
"wasmtime/wat", "wasmtime/wat",
"wasmtime/parallel-compilation", "wasmtime/parallel-compilation",
"wasi-nn", "wasi-nn",
"memfd",
"pooling-allocator", "pooling-allocator",
] ]
jitdump = ["wasmtime/jitdump"] jitdump = ["wasmtime/jitdump"]

2
crates/wasmtime/Cargo.toml
View File

@@ -51,7 +51,7 @@ wasi-cap-std-sync = { path = "../wasi-common/cap-std-sync" }
maintenance = { status = "actively-developed" } maintenance = { status = "actively-developed" }
[features] [features]
default = ['async', 'cache', 'wat', 'jitdump', 'parallel-compilation', 'cranelift', 'pooling-allocator', 'memfd'] default = ['async', 'cache', 'wat', 'jitdump', 'parallel-compilation', 'cranelift', 'pooling-allocator']
# An on-by-default feature enabling runtime compilation of WebAssembly modules # An on-by-default feature enabling runtime compilation of WebAssembly modules
# with the Cranelift compiler. Cranelift is the default compilation backend of # with the Cranelift compiler. Cranelift is the default compilation backend of