From 88b53b12aaa67f4258ff48336e0e0b9aa21b8b19 Mon Sep 17 00:00:00 2001 From: Chris Fallin Date: Mon, 7 Feb 2022 13:44:53 -0800 Subject: [PATCH] Turn off memfd by default, at least for this upcoming release. (#3774) Since memfd support just landed, and has had only ~0.5 weeks to bake with fuzzing, we want to make release 0.34.0 of Wasmtime without it enabled by default. This PR disables memfd by default; it can be enabled by specifying the `memfd` feature for the `wasmtime` crate, or when building the commandline binary. We plan to explicitly add memfd-enabled fuzzing targets, let that go for a while, then probably re-enable memfd in the subsequent release if no issues come up. --- Cargo.toml | 1 - crates/wasmtime/Cargo.toml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 71667869a5..22c28772f9 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -94,7 +94,6 @@ default = [ "wasmtime/wat", "wasmtime/parallel-compilation", "wasi-nn", - "memfd", "pooling-allocator", ] jitdump = ["wasmtime/jitdump"] diff --git a/crates/wasmtime/Cargo.toml b/crates/wasmtime/Cargo.toml index 2fc4440c71..764c73e3ae 100644 --- a/crates/wasmtime/Cargo.toml +++ b/crates/wasmtime/Cargo.toml @@ -51,7 +51,7 @@ wasi-cap-std-sync = { path = "../wasi-common/cap-std-sync" } maintenance = { status = "actively-developed" } [features] -default = ['async', 'cache', 'wat', 'jitdump', 'parallel-compilation', 'cranelift', 'pooling-allocator', 'memfd'] +default = ['async', 'cache', 'wat', 'jitdump', 'parallel-compilation', 'cranelift', 'pooling-allocator'] # An on-by-default feature enabling runtime compilation of WebAssembly modules # with the Cranelift compiler. Cranelift is the default compilation backend of