Migrate back to std:: stylistically (#554)

* Migrate back to `std::` stylistically

This commit moves away from idioms such as `alloc::` and `core::` as
imports of standard data structures and types. Instead it migrates all
crates to uniformly use `std::` for importing standard data structures
and types. This also removes the `std` and `core` features from all
crates to and removes any conditional checking for `feature = "std"`

All of this support was previously added in #407 in an effort to make
wasmtime/cranelift "`no_std` compatible". Unfortunately though this
change comes at a cost:

* The usage of `alloc` and `core` isn't idiomatic. Especially trying to
  dual between types like `HashMap` from `std` as well as from
  `hashbrown` causes imports to be surprising in some cases.
* Unfortunately there was no CI check that crates were `no_std`, so none
  of them actually were. Many crates still imported from `std` or
  depended on crates that used `std`.

It's important to note, however, that **this does not mean that wasmtime
will not run in embedded environments**. The style of the code today and
idioms aren't ready in Rust to support this degree of multiplexing and
makes it somewhat difficult to keep up with the style of `wasmtime`.
Instead it's intended that embedded runtime support will be added as
necessary. Currently only `std` is necessary to build `wasmtime`, and
platforms that natively need to execute `wasmtime` will need to use a
Rust target that supports `std`. Note though that not all of `std` needs
to be supported, but instead much of it could be configured off to
return errors, and `wasmtime` would be configured to gracefully handle
errors.

The goal of this PR is to move `wasmtime` back to idiomatic usage of
features/`std`/imports/etc and help development in the short-term.
Long-term when platform concerns arise (if any) they can be addressed by
moving back to `no_std` crates (but fixing the issues mentioned above)
or ensuring that the target in Rust has `std` available.

* Start filling out platform support doc

crates/environ/src/address_map.rs

@@ -1,7 +1,6 @@
 //! Data structures to provide transformation of the source
 // addresses of a WebAssembly module into the native code.
 
-use alloc::vec::Vec;
 use cranelift_codegen::ir;
 use cranelift_entity::PrimaryMap;
 use cranelift_wasm::DefinedFuncIndex;

crates/environ/src/cache.rs

@@ -2,8 +2,6 @@ use crate::address_map::{ModuleAddressMap, ValueLabelsRanges};
 use crate::compilation::{Compilation, Relocations, Traps};
 use crate::module::Module;
 use crate::module_environ::FunctionBodyData;
-use alloc::string::{String, ToString};
-use core::hash::Hasher;
 use cranelift_codegen::{ir, isa};
 use cranelift_entity::PrimaryMap;
 use cranelift_wasm::DefinedFuncIndex;
@@ -12,6 +10,7 @@ use log::{debug, trace, warn};
 use serde::{Deserialize, Serialize};
 use sha2::{Digest, Sha256};
 use std::fs;
+use std::hash::Hasher;
 use std::io::Write;
 use std::path::{Path, PathBuf};
 

crates/environ/src/cache/config.rs

@@ -1,9 +1,6 @@
 //! Module for configuring the cache system.
 
 use super::worker;
-use alloc::string::{String, ToString};
-use alloc::vec::Vec;
-use core::time::Duration;
 use directories::ProjectDirs;
 use lazy_static::lazy_static;
 use log::{debug, error, trace, warn};
@@ -17,6 +14,7 @@ use std::fs;
 use std::mem;
 use std::path::{Path, PathBuf};
 use std::sync::atomic::{AtomicBool, Ordering};
+use std::time::Duration;
 
 // wrapped, so we have named section in config,
 // also, for possible future compatibility

crates/environ/src/cache/config/tests.rs

@@ -1,7 +1,7 @@
 use super::CacheConfig;
-use core::time::Duration;
 use std::fs;
 use std::path::PathBuf;
+use std::time::Duration;
 use tempfile::{self, TempDir};
 
 // note: config loading during validation creates cache directory to canonicalize its path,

crates/environ/src/cache/tests.rs

@@ -3,15 +3,13 @@ use super::*;
 use crate::address_map::{FunctionAddressMap, InstructionAddressMap};
 use crate::compilation::{CompiledFunction, Relocation, RelocationTarget, TrapInformation};
 use crate::module::{MemoryPlan, MemoryStyle, Module};
-use alloc::boxed::Box;
-use alloc::vec::Vec;
-use core::cmp::min;
 use cranelift_codegen::{binemit, ir, isa, settings, ValueLocRange};
 use cranelift_entity::EntityRef;
 use cranelift_entity::{PrimaryMap, SecondaryMap};
 use cranelift_wasm::{DefinedFuncIndex, FuncIndex, Global, GlobalInit, Memory, SignatureIndex};
 use rand::rngs::SmallRng;
 use rand::{Rng, SeedableRng};
+use std::cmp::min;
 use std::fs;
 use std::str::FromStr;
 use target_lexicon::triple;

crates/environ/src/cache/worker.rs

@@ -6,12 +6,10 @@
 //! Background tasks can be CPU intensive, but the worker thread has low priority.
 
 use super::{cache_config, fs_write_atomic, CacheConfig};
-use alloc::vec::Vec;
-use core::cmp;
-use core::time::Duration;
 use log::{debug, info, trace, warn};
 use serde::{Deserialize, Serialize};
 use spin::Once;
+use std::cmp;
 use std::collections::HashMap;
 use std::ffi::OsStr;
 use std::fs;
@@ -21,6 +19,7 @@ use std::sync::mpsc::{sync_channel, Receiver, SyncSender};
 #[cfg(test)]
 use std::sync::{Arc, Condvar, Mutex};
 use std::thread;
+use std::time::Duration;
 #[cfg(not(test))]
 use std::time::SystemTime;
 #[cfg(test)]
@@ -234,7 +233,7 @@ impl WorkerThread {
 
     #[cfg(target_os = "windows")]
     fn lower_thread_priority() {
-        use core::convert::TryInto;
+        use std::convert::TryInto;
         use winapi::um::processthreadsapi::{GetCurrentThread, SetThreadPriority};
         use winapi::um::winbase::THREAD_MODE_BACKGROUND_BEGIN;
 

crates/environ/src/cache/worker/tests.rs

@@ -1,7 +1,7 @@
 use super::*;
 use crate::cache::config::tests::test_prolog;
-use core::iter::repeat;
 use more_asserts::{assert_ge, assert_gt, assert_lt};
+use std::iter::repeat;
 use std::process;
 // load_config! comes from crate::cache(::config::tests);
 

crates/environ/src/compilation.rs

@@ -4,7 +4,6 @@
 use crate::address_map::{ModuleAddressMap, ValueLabelsRanges};
 use crate::module;
 use crate::module_environ::FunctionBodyData;
-use alloc::vec::Vec;
 use cranelift_codegen::{binemit, ir, isa};
 use cranelift_entity::PrimaryMap;
 use cranelift_wasm::{DefinedFuncIndex, FuncIndex, ModuleTranslationState, WasmError};

crates/environ/src/cranelift.rs

@@ -14,7 +14,6 @@ use crate::func_environ::{
 };
 use crate::module::Module;
 use crate::module_environ::FunctionBodyData;
-use alloc::vec::Vec;
 use cranelift_codegen::binemit;
 use cranelift_codegen::ir;
 use cranelift_codegen::ir::ExternalName;

crates/environ/src/func_environ.rs

@@ -1,9 +1,6 @@
 use crate::module::{MemoryPlan, MemoryStyle, Module, TableStyle};
 use crate::vmoffsets::VMOffsets;
 use crate::WASM_PAGE_SIZE;
-use alloc::vec::Vec;
-use core::clone::Clone;
-use core::convert::TryFrom;
 use cranelift_codegen::cursor::FuncCursor;
 use cranelift_codegen::ir;
 use cranelift_codegen::ir::condcodes::*;
@@ -18,6 +15,7 @@ use cranelift_wasm::{
 };
 #[cfg(feature = "lightbeam")]
 use cranelift_wasm::{DefinedFuncIndex, DefinedGlobalIndex, DefinedMemoryIndex, DefinedTableIndex};
+use std::convert::TryFrom;
 
 /// Compute an `ir::ExternalName` for a given wasm function index.
 pub fn get_func_name(func_index: FuncIndex) -> ir::ExternalName {

crates/environ/src/lib.rs

@@ -5,7 +5,6 @@
 
 #![deny(missing_docs, trivial_numeric_casts, unused_extern_crates)]
 #![warn(unused_import_braces)]
-#![cfg_attr(feature = "std", deny(unstable_features))]
 #![cfg_attr(feature = "clippy", plugin(clippy(conf_file = "../../clippy.toml")))]
 #![cfg_attr(
     feature = "cargo-clippy",
@@ -25,8 +24,6 @@
     )
 )]
 
-extern crate alloc;
-
 mod address_map;
 mod compilation;
 mod func_environ;

crates/environ/src/module.rs

@@ -2,10 +2,6 @@
 
 use crate::module_environ::FunctionBodyData;
 use crate::tunables::Tunables;
-use alloc::boxed::Box;
-use alloc::string::String;
-use alloc::vec::Vec;
-use core::hash::{Hash, Hasher};
 use cranelift_codegen::ir;
 use cranelift_entity::{EntityRef, PrimaryMap};
 use cranelift_wasm::{
@@ -14,6 +10,7 @@ use cranelift_wasm::{
 };
 use indexmap::IndexMap;
 use more_asserts::assert_ge;
+use std::hash::{Hash, Hasher};
 
 /// A WebAssembly table initializer.
 #[derive(Clone, Debug, Hash)]

crates/environ/src/module_environ.rs

@@ -1,10 +1,6 @@
 use crate::func_environ::FuncEnvironment;
 use crate::module::{Export, MemoryPlan, Module, TableElements, TablePlan};
 use crate::tunables::Tunables;
-use alloc::boxed::Box;
-use alloc::string::String;
-use alloc::vec::Vec;
-use core::convert::TryFrom;
 use cranelift_codegen::ir;
 use cranelift_codegen::ir::{AbiParam, ArgumentPurpose};
 use cranelift_codegen::isa::TargetFrontendConfig;
@@ -13,6 +9,7 @@ use cranelift_wasm::{
     self, translate_module, DefinedFuncIndex, FuncIndex, Global, GlobalIndex, Memory, MemoryIndex,
     ModuleTranslationState, SignatureIndex, Table, TableIndex, WasmResult,
 };
+use std::convert::TryFrom;
 
 /// Contains function data: byte code and its offset in the module.
 #[derive(Hash)]

crates/environ/src/vmoffsets.rs

@@ -3,13 +3,13 @@
 
 use crate::module::Module;
 use crate::BuiltinFunctionIndex;
-use core::convert::TryFrom;
 use cranelift_codegen::ir;
 use cranelift_wasm::{
     DefinedGlobalIndex, DefinedMemoryIndex, DefinedTableIndex, FuncIndex, GlobalIndex, MemoryIndex,
     SignatureIndex, TableIndex,
 };
 use more_asserts::assert_lt;
+use std::convert::TryFrom;
 
 #[cfg(target_pointer_width = "32")]
 fn cast_to_u32(sz: usize) -> u32 {