T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x64: Remove some unreachable code that's been ported to ISLE

Browse Source
This commit is contained in:
Nick Fitzgerald
2021-11-05 14:28:03 -07:00
parent 00e7ca206f
commit 30d206779e
1 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cranelift/codegen/src/isa/x64/lower.rs
View File

@@ -1545,20 +1545,7 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>(
} else if ty == types::I64X2 { } else if ty == types::I64X2 {
unreachable!("implemented in ISLE: {}", ctx.dfg().display_inst(insn)); unreachable!("implemented in ISLE: {}", ctx.dfg().display_inst(insn));
} else if ty.lane_count() > 1 { } else if ty.lane_count() > 1 {
// Emit single instruction lowerings for the remaining vector unreachable!("implemented in ISLE: {}", ctx.dfg().display_inst(insn));
// multiplications.
let sse_op = match ty {
types::I16X8 => SseOpcode::Pmullw,
types::I32X4 => SseOpcode::Pmulld,
_ => panic!("Unsupported type for packed imul instruction: {}", ty),
};
let lhs = put_input_in_reg(ctx, inputs[0]);
let rhs = input_to_reg_mem(ctx, inputs[1]);
let dst = get_output_reg(ctx, outputs[0]).only_reg().unwrap();
// Move the `lhs` to the same register as `dst`.
ctx.emit(Inst::gen_move(dst, lhs, ty));
ctx.emit(Inst::xmm_rm_r(sse_op, rhs, dst));
} else if ty == types::I128 || ty == types::B128 { } else if ty == types::I128 || ty == types::B128 {
// Handle 128-bit multiplications. // Handle 128-bit multiplications.
let lhs = put_input_in_regs(ctx, inputs[0]); let lhs = put_input_in_regs(ctx, inputs[0]);