efdfc361f8
* Allow WASI to open directories without O_DIRECTORY The `O_DIRECTORY` flag is a request that open should fail if the named path is not a directory. Opening a path which turns out to be a directory is not supposed to fail if this flag is not specified. However, wasi-common required callers to use it when opening directories. With this PR, we always open the path the same way whether or not the `O_DIRECTORY` flag is specified. However, after opening it, we `stat` it to check whether it turned out to be a directory, and determine which operations the file descriptor should support accordingly. In addition, we explicitly check whether the precondition defined by `O_DIRECTORY` is satisfied. Closes #4947 and closes #4967, which were earlier attempts at fixing the same issue, but which had race conditions. prtest:full * Add tests from #4967/#4947 This test was authored by Roman Volosatovs <rvolosatovs@riseup.net> as part of #4947. * Tests: Close FDs before trying to unlink files On Windows, when opening a path which might be a directory using `CreateFile`, cap-primitives also removes the `FILE_SHARE_DELETE` mode. That means that if we implement WASI's `path_open` such that it always uses `CreateFile` on Windows, for both files and directories, then holding an open file handle prevents deletion of that file. So I'm changing these test programs to make sure they've closed the handle before trying to delete the file.
wasi-common
A Bytecode Alliance project
A library providing a common implementation of WASI hostcalls for re-use in any WASI-enabled runtime.
The wasi-common crate will ultimately serve as a library providing a common implementation of
WASI hostcalls for re-use in any WASI (and potentially non-WASI) runtimes
such as Wasmtime and Lucet.
The library is an adaption of lucet-wasi crate from the Lucet project, and it is currently based on 40ae1df git revision.
Please note that the library requires Rust compiler version at least 1.37.0.
Supported syscalls
*nix
In our *nix implementation, we currently support the entire WASI API
with the exception of the proc_raise hostcall, as it is expected to
be dropped entirely from WASI.
Windows
In our Windows implementation, we currently support the minimal subset of WASI API which allows for running the very basic "Hello world!" style WASM apps. More coming shortly, so stay tuned!
Development hints
When testing the crate, you may want to enable and run full wasm32 integration testsuite. This
requires wasm32-wasi target installed which can be done as follows using rustup
rustup target add wasm32-wasi
Now, you should be able to run the integration testsuite by running cargo test on the
test-programs package with test-programs/test_programs feature enabled:
cargo test --features test-programs/test_programs --package test-programs