c161b0d103
There are two cases: 1. It seems that grep on macOS exits as soon as it finds the first match. This makes cargo unhappy and it prints message like "failed printing to stdout: Broken pipe (os error 32)". The solution is to fully consume the output from cargo. I choose to use tee for this task. 2. When in a strict mode, bash complains that $1 is not defined (when it's actually not defined in case of omitting --install). The solution is to apply bash substitution magic: when $1 is undefined or set to null substitute it with empty string.
41 lines
1.5 KiB
Bash
Executable File
41 lines
1.5 KiB
Bash
Executable File
#!/bin/bash
|
|
set -euo pipefail
|
|
|
|
# Usage: check-rustfmt.sh [--install]
|
|
#
|
|
# Check that the desired version of rustfmt is installed.
|
|
#
|
|
# Rustfmt is still immature enough that its formatting decisions can change
|
|
# between versions. This makes it difficult to enforce a certain style in a
|
|
# test script since not all developers will upgrade rustfmt at the same time.
|
|
# To work around this, we only verify formatting when a specific version of
|
|
# rustfmt is installed.
|
|
#
|
|
# Exits 0 if the right version of rustfmt is installed, 1 otherwise.
|
|
#
|
|
# With the --install option, also tries to install the right version.
|
|
|
|
# This version should always be bumped to the newest version available that
|
|
# works with stable Rust.
|
|
# ... but not 0.10.0, since it's the same as 0.9.0 except for a deprecation
|
|
# error (and it requires --force to disable the error and enable normal
|
|
# operation, however that doesn't appear to be possible through "cargo fmt").
|
|
VERS="0.9.0"
|
|
|
|
if cargo install --list | tee /dev/null | grep -q "^rustfmt v$VERS"; then
|
|
exit 0
|
|
fi
|
|
|
|
if [[ ${1:-""} != "--install" ]]; then
|
|
echo "********************************************************************"
|
|
echo "* Please install rustfmt v$VERS to verify formatting. *"
|
|
echo "* If a newer version of rustfmt is available, update this script. *"
|
|
echo "********************************************************************"
|
|
echo "$0 --install"
|
|
sleep 1
|
|
exit 1
|
|
fi
|
|
|
|
echo "Installing rustfmt v$VERS."
|
|
cargo install --force --vers="$VERS" rustfmt
|