* Migrate back to `std::` stylistically This commit moves away from idioms such as `alloc::` and `core::` as imports of standard data structures and types. Instead it migrates all crates to uniformly use `std::` for importing standard data structures and types. This also removes the `std` and `core` features from all crates to and removes any conditional checking for `feature = "std"` All of this support was previously added in #407 in an effort to make wasmtime/cranelift "`no_std` compatible". Unfortunately though this change comes at a cost: * The usage of `alloc` and `core` isn't idiomatic. Especially trying to dual between types like `HashMap` from `std` as well as from `hashbrown` causes imports to be surprising in some cases. * Unfortunately there was no CI check that crates were `no_std`, so none of them actually were. Many crates still imported from `std` or depended on crates that used `std`. It's important to note, however, that **this does not mean that wasmtime will not run in embedded environments**. The style of the code today and idioms aren't ready in Rust to support this degree of multiplexing and makes it somewhat difficult to keep up with the style of `wasmtime`. Instead it's intended that embedded runtime support will be added as necessary. Currently only `std` is necessary to build `wasmtime`, and platforms that natively need to execute `wasmtime` will need to use a Rust target that supports `std`. Note though that not all of `std` needs to be supported, but instead much of it could be configured off to return errors, and `wasmtime` would be configured to gracefully handle errors. The goal of this PR is to move `wasmtime` back to idiomatic usage of features/`std`/imports/etc and help development in the short-term. Long-term when platform concerns arise (if any) they can be addressed by moving back to `no_std` crates (but fixing the issues mentioned above) or ensuring that the target in Rust has `std` available. * Start filling out platform support doc
132 lines
3.7 KiB
Rust
132 lines
3.7 KiB
Rust
//! Interface to low-level signal-handling mechanisms.
|
|
|
|
#![allow(non_upper_case_globals)]
|
|
#![allow(non_camel_case_types)]
|
|
#![allow(non_snake_case)]
|
|
|
|
use crate::vmcontext::VMContext;
|
|
use lazy_static::lazy_static;
|
|
use std::borrow::{Borrow, BorrowMut};
|
|
use std::cell::Cell;
|
|
use std::sync::RwLock;
|
|
|
|
#[derive(Default)]
|
|
struct TrapContext {
|
|
tried_to_install_signal_handlers: Cell<bool>,
|
|
have_signal_handlers: Cell<bool>,
|
|
}
|
|
|
|
extern "C" {
|
|
fn EnsureEagerSignalHandlers() -> libc::c_int;
|
|
#[cfg(any(target_os = "macos", target_os = "ios"))]
|
|
fn EnsureDarwinMachPorts() -> libc::c_int;
|
|
}
|
|
|
|
struct InstallState {
|
|
tried: bool,
|
|
success: bool,
|
|
}
|
|
|
|
impl InstallState {
|
|
fn new() -> Self {
|
|
Self {
|
|
tried: false,
|
|
success: false,
|
|
}
|
|
}
|
|
}
|
|
|
|
lazy_static! {
|
|
static ref EAGER_INSTALL_STATE: RwLock<InstallState> = RwLock::new(InstallState::new());
|
|
static ref LAZY_INSTALL_STATE: RwLock<InstallState> = RwLock::new(InstallState::new());
|
|
}
|
|
|
|
/// This function performs the low-overhead signal handler initialization that we
|
|
/// want to do eagerly to ensure a more-deterministic global process state. This
|
|
/// is especially relevant for signal handlers since handler ordering depends on
|
|
/// installation order: the wasm signal handler must run *before* the other crash
|
|
/// handlers and since POSIX signal handlers work LIFO, this function needs to be
|
|
/// called at the end of the startup process, after other handlers have been
|
|
/// installed. This function can thus be called multiple times, having no effect
|
|
/// after the first call.
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_init_eager() {
|
|
let mut locked = EAGER_INSTALL_STATE.write().unwrap();
|
|
let state = locked.borrow_mut();
|
|
|
|
if state.tried {
|
|
return;
|
|
}
|
|
|
|
state.tried = true;
|
|
assert!(!state.success);
|
|
|
|
if unsafe { EnsureEagerSignalHandlers() == 0 } {
|
|
return;
|
|
}
|
|
|
|
state.success = true;
|
|
}
|
|
|
|
thread_local! {
|
|
static TRAP_CONTEXT: TrapContext = TrapContext::default();
|
|
}
|
|
|
|
/// Assuming `EnsureEagerProcessSignalHandlers` has already been called,
|
|
/// this function performs the full installation of signal handlers which must
|
|
/// be performed per-thread. This operation may incur some overhead and
|
|
/// so should be done only when needed to use wasm.
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_init_finish(vmctx: &mut VMContext) {
|
|
if !TRAP_CONTEXT.with(|cx| cx.tried_to_install_signal_handlers.get()) {
|
|
TRAP_CONTEXT.with(|cx| {
|
|
cx.tried_to_install_signal_handlers.set(true);
|
|
assert!(!cx.have_signal_handlers.get());
|
|
});
|
|
|
|
{
|
|
let locked = EAGER_INSTALL_STATE.read().unwrap();
|
|
let state = locked.borrow();
|
|
assert!(
|
|
state.tried,
|
|
"call wasmtime_init_eager before calling wasmtime_init_finish"
|
|
);
|
|
if !state.success {
|
|
return;
|
|
}
|
|
}
|
|
|
|
#[cfg(any(target_os = "macos", target_os = "ios"))]
|
|
ensure_darwin_mach_ports();
|
|
|
|
TRAP_CONTEXT.with(|cx| {
|
|
cx.have_signal_handlers.set(true);
|
|
})
|
|
}
|
|
|
|
let instance = unsafe { vmctx.instance() };
|
|
let have_signal_handlers = TRAP_CONTEXT.with(|cx| cx.have_signal_handlers.get());
|
|
if !have_signal_handlers && instance.needs_signal_handlers() {
|
|
panic!("failed to install signal handlers");
|
|
}
|
|
}
|
|
|
|
#[cfg(any(target_os = "macos", target_os = "ios"))]
|
|
fn ensure_darwin_mach_ports() {
|
|
let mut locked = LAZY_INSTALL_STATE.write().unwrap();
|
|
let state = locked.borrow_mut();
|
|
|
|
if state.tried {
|
|
return;
|
|
}
|
|
|
|
state.tried = true;
|
|
assert!(!state.success);
|
|
|
|
if unsafe { EnsureDarwinMachPorts() != 0 } {
|
|
return;
|
|
}
|
|
|
|
state.success = true;
|
|
}
|