* Preserve full native stack traces in errors This commit builds on #759 by performing a few refactorings: * The `backtrace` crate is updated to 0.3.42 which incorporates the Windows-specific stack-walking code, so that's no longer needed. * A full `backtrace::Backtrace` type is held in a trap at all times. * The trap structures in the `wasmtime-*` internal crates were refactored a bit to preserve more information and deal with raw values rather than converting between various types and strings. * The `wasmtime::Trap` type has been updated with these various changes. Eventually I think we'll want to likely render full stack traces (and/or partial wasm ones) into error messages, but for now that's left as-is and we can always improve it later. I suspect the most relevant thing we need to do is to implement function name symbolication for wasm functions first, and then afterwards we can incorporate native function names! * Fix some test suite assertions
294 lines
9.9 KiB
Rust
294 lines
9.9 KiB
Rust
#[cfg(not(target_os = "windows"))]
|
|
mod tests {
|
|
use anyhow::Result;
|
|
use std::rc::Rc;
|
|
use std::sync::atomic::{AtomicBool, Ordering};
|
|
use wasmtime::*;
|
|
|
|
const WAT1: &str = r#"
|
|
(module
|
|
(func $read (export "read") (result i32)
|
|
(i32.load (i32.const 0))
|
|
)
|
|
(func $read_out_of_bounds (export "read_out_of_bounds") (result i32)
|
|
(i32.load
|
|
(i32.mul
|
|
;; memory size in Wasm pages
|
|
(memory.size)
|
|
;; Wasm page size
|
|
(i32.const 65536)
|
|
)
|
|
)
|
|
)
|
|
(func $start
|
|
(i32.store (i32.const 0) (i32.const 123))
|
|
)
|
|
(start $start)
|
|
(memory (export "memory") 1 4)
|
|
)
|
|
"#;
|
|
|
|
const WAT2: &str = r#"
|
|
(module
|
|
(import "other_module" "read" (func $other_module.read (result i32)))
|
|
(func $run (export "run") (result i32)
|
|
call $other_module.read)
|
|
)
|
|
"#;
|
|
|
|
fn invoke_export(instance: &Instance, func_name: &str) -> Result<Box<[Val]>, Trap> {
|
|
let ret = instance
|
|
.find_export_by_name(func_name)
|
|
.unwrap()
|
|
.func()
|
|
.unwrap()
|
|
.call(&[])?;
|
|
Ok(ret)
|
|
}
|
|
|
|
// Locate "memory" export, get base address and size and set memory protection to PROT_NONE
|
|
fn set_up_memory(instance: &Instance) -> (*mut u8, usize) {
|
|
let mem_export = instance.get_wasmtime_memory().expect("memory");
|
|
|
|
let (base, length) = if let wasmtime_runtime::Export::Memory {
|
|
definition,
|
|
vmctx: _,
|
|
memory: _,
|
|
} = mem_export
|
|
{
|
|
unsafe {
|
|
let definition = std::ptr::read(definition);
|
|
(definition.base, definition.current_length)
|
|
}
|
|
} else {
|
|
panic!("expected memory");
|
|
};
|
|
|
|
// So we can later trigger SIGSEGV by performing a read
|
|
unsafe {
|
|
libc::mprotect(base as *mut libc::c_void, length, libc::PROT_NONE);
|
|
}
|
|
|
|
println!("memory: base={:?}, length={}", base, length);
|
|
|
|
(base, length)
|
|
}
|
|
|
|
fn handle_sigsegv(
|
|
base: *mut u8,
|
|
length: usize,
|
|
signum: libc::c_int,
|
|
siginfo: *const libc::siginfo_t,
|
|
) -> bool {
|
|
println!("Hello from instance signal handler!");
|
|
// SIGSEGV on Linux, SIGBUS on Mac
|
|
if libc::SIGSEGV == signum || libc::SIGBUS == signum {
|
|
let si_addr: *mut libc::c_void = unsafe { (*siginfo).si_addr() };
|
|
// Any signal from within module's memory we handle ourselves
|
|
let result = (si_addr as u64) < (base as u64) + (length as u64);
|
|
// Remove protections so the execution may resume
|
|
unsafe {
|
|
libc::mprotect(
|
|
base as *mut libc::c_void,
|
|
length,
|
|
libc::PROT_READ | libc::PROT_WRITE,
|
|
);
|
|
}
|
|
println!("signal handled: {}", result);
|
|
result
|
|
} else {
|
|
// Otherwise, we forward to wasmtime's signal handler.
|
|
false
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn test_custom_signal_handler_single_instance() -> Result<()> {
|
|
let engine = Engine::new(&Config::default());
|
|
let store = Store::new(&engine);
|
|
let data = wat::parse_str(WAT1)?;
|
|
let module = Module::new(&store, &data)?;
|
|
let instance = Instance::new(&module, &[])?;
|
|
|
|
let (base, length) = set_up_memory(&instance);
|
|
instance.set_signal_handler(move |signum, siginfo, _| {
|
|
handle_sigsegv(base, length, signum, siginfo)
|
|
});
|
|
|
|
let exports = instance.exports();
|
|
assert!(!exports.is_empty());
|
|
|
|
// these invoke wasmtime_call_trampoline from action.rs
|
|
{
|
|
println!("calling read...");
|
|
let result = invoke_export(&instance, "read").expect("read succeeded");
|
|
assert_eq!(123, result[0].unwrap_i32());
|
|
}
|
|
|
|
{
|
|
println!("calling read_out_of_bounds...");
|
|
let trap = invoke_export(&instance, "read_out_of_bounds").unwrap_err();
|
|
assert!(
|
|
trap.message()
|
|
.starts_with("wasm trap: out of bounds memory access"),
|
|
"bad trap message: {:?}",
|
|
trap.message()
|
|
);
|
|
}
|
|
|
|
// these invoke wasmtime_call_trampoline from callable.rs
|
|
{
|
|
let read_func = exports[0]
|
|
.func()
|
|
.expect("expected a 'read' func in the module");
|
|
println!("calling read...");
|
|
let result = read_func.call(&[]).expect("expected function not to trap");
|
|
assert_eq!(123i32, result[0].clone().unwrap_i32());
|
|
}
|
|
|
|
{
|
|
let read_out_of_bounds_func = exports[1]
|
|
.func()
|
|
.expect("expected a 'read_out_of_bounds' func in the module");
|
|
println!("calling read_out_of_bounds...");
|
|
let trap = read_out_of_bounds_func.call(&[]).unwrap_err();
|
|
assert!(trap
|
|
.message()
|
|
.starts_with("wasm trap: out of bounds memory access"));
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn test_custom_signal_handler_multiple_instances() -> Result<()> {
|
|
let engine = Engine::new(&Config::default());
|
|
let store = Store::new(&engine);
|
|
let data = wat::parse_str(WAT1)?;
|
|
let module = Module::new(&store, &data)?;
|
|
|
|
// Set up multiple instances
|
|
|
|
let instance1 = Instance::new(&module, &[])?;
|
|
let instance1_handler_triggered = Rc::new(AtomicBool::new(false));
|
|
|
|
{
|
|
let (base1, length1) = set_up_memory(&instance1);
|
|
|
|
instance1.set_signal_handler({
|
|
let instance1_handler_triggered = instance1_handler_triggered.clone();
|
|
move |_signum, _siginfo, _context| {
|
|
// Remove protections so the execution may resume
|
|
unsafe {
|
|
libc::mprotect(
|
|
base1 as *mut libc::c_void,
|
|
length1,
|
|
libc::PROT_READ | libc::PROT_WRITE,
|
|
);
|
|
}
|
|
instance1_handler_triggered.store(true, Ordering::SeqCst);
|
|
println!(
|
|
"Hello from instance1 signal handler! {}",
|
|
instance1_handler_triggered.load(Ordering::SeqCst)
|
|
);
|
|
true
|
|
}
|
|
});
|
|
}
|
|
|
|
let instance2 = Instance::new(&module, &[]).expect("failed to instantiate module");
|
|
let instance2_handler_triggered = Rc::new(AtomicBool::new(false));
|
|
|
|
{
|
|
let (base2, length2) = set_up_memory(&instance2);
|
|
|
|
instance2.set_signal_handler({
|
|
let instance2_handler_triggered = instance2_handler_triggered.clone();
|
|
move |_signum, _siginfo, _context| {
|
|
// Remove protections so the execution may resume
|
|
unsafe {
|
|
libc::mprotect(
|
|
base2 as *mut libc::c_void,
|
|
length2,
|
|
libc::PROT_READ | libc::PROT_WRITE,
|
|
);
|
|
}
|
|
instance2_handler_triggered.store(true, Ordering::SeqCst);
|
|
println!(
|
|
"Hello from instance2 signal handler! {}",
|
|
instance2_handler_triggered.load(Ordering::SeqCst)
|
|
);
|
|
true
|
|
}
|
|
});
|
|
}
|
|
|
|
// Invoke both instances and trigger both signal handlers
|
|
|
|
// First instance1
|
|
{
|
|
let exports1 = instance1.exports();
|
|
assert!(!exports1.is_empty());
|
|
|
|
println!("calling instance1.read...");
|
|
let result = invoke_export(&instance1, "read").expect("read succeeded");
|
|
assert_eq!(123, result[0].unwrap_i32());
|
|
assert_eq!(
|
|
instance1_handler_triggered.load(Ordering::SeqCst),
|
|
true,
|
|
"instance1 signal handler has been triggered"
|
|
);
|
|
}
|
|
|
|
// And then instance2
|
|
{
|
|
let exports2 = instance2.exports();
|
|
assert!(!exports2.is_empty());
|
|
|
|
println!("calling instance2.read...");
|
|
let result = invoke_export(&instance2, "read").expect("read succeeded");
|
|
assert_eq!(123, result[0].unwrap_i32());
|
|
assert_eq!(
|
|
instance2_handler_triggered.load(Ordering::SeqCst),
|
|
true,
|
|
"instance1 signal handler has been triggered"
|
|
);
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn test_custom_signal_handler_instance_calling_another_instance() -> Result<()> {
|
|
let engine = Engine::new(&Config::default());
|
|
let store = Store::new(&engine);
|
|
|
|
// instance1 which defines 'read'
|
|
let data1 = wat::parse_str(WAT1)?;
|
|
let module1 = Module::new(&store, &data1)?;
|
|
let instance1 = Instance::new(&module1, &[])?;
|
|
let (base1, length1) = set_up_memory(&instance1);
|
|
instance1.set_signal_handler(move |signum, siginfo, _| {
|
|
println!("instance1");
|
|
handle_sigsegv(base1, length1, signum, siginfo)
|
|
});
|
|
|
|
let instance1_exports = instance1.exports();
|
|
assert!(!instance1_exports.is_empty());
|
|
let instance1_read = instance1_exports[0].clone();
|
|
|
|
// instance2 wich calls 'instance1.read'
|
|
let data2 = wat::parse_str(WAT2)?;
|
|
let module2 = Module::new(&store, &data2)?;
|
|
let instance2 = Instance::new(&module2, &[instance1_read])?;
|
|
// since 'instance2.run' calls 'instance1.read' we need to set up the signal handler to handle
|
|
// SIGSEGV originating from within the memory of instance1
|
|
instance2.set_signal_handler(move |signum, siginfo, _| {
|
|
handle_sigsegv(base1, length1, signum, siginfo)
|
|
});
|
|
|
|
println!("calling instance2.run");
|
|
let result = invoke_export(&instance2, "run")?;
|
|
assert_eq!(123, result[0].unwrap_i32());
|
|
Ok(())
|
|
}
|
|
}
|