* Revert fstatat on *nix and test symlinks in path_filestat calls
This commit effectively reverts too eager refactoring on my part which
resulted in incorrect `path_filestat_{get, set_times}` behaviour on
*nix hosts. In the presence of symlinks, neither of the calls would
work properly.
In order to shield ourselves from similar errors in the future, I've
augmented the `path_filestat` test cases with symlink checks as well.
* Pass appropriate flags to fstatat and utimensat
* Fix formatting
* Fix Windows build
* Expand final symlinks if follow is set on Windows
* Fix formatting
* Do not follow symlinks unless specified on Windows
* Update comments and restart CI
* Skip testing volatile atim field
164 lines
5.4 KiB
Rust
164 lines
5.4 KiB
Rust
use more_asserts::assert_gt;
|
|
use std::{env, process};
|
|
use wasi_tests::open_scratch_directory;
|
|
|
|
unsafe fn test_path_filestat(dir_fd: wasi::Fd) {
|
|
let mut fdstat = wasi::fd_fdstat_get(dir_fd).expect("fd_fdstat_get");
|
|
assert_ne!(
|
|
fdstat.fs_rights_base & wasi::RIGHTS_PATH_FILESTAT_GET,
|
|
0,
|
|
"the scratch directory should have RIGHT_PATH_FILESTAT_GET as base right",
|
|
);
|
|
assert_ne!(
|
|
fdstat.fs_rights_inheriting & wasi::RIGHTS_PATH_FILESTAT_GET,
|
|
0,
|
|
"the scratch directory should have RIGHT_PATH_FILESTAT_GET as base right",
|
|
);
|
|
|
|
// Create a file in the scratch directory.
|
|
let file_fd = wasi::path_open(
|
|
dir_fd,
|
|
0,
|
|
"file",
|
|
wasi::OFLAGS_CREAT,
|
|
wasi::RIGHTS_FD_READ | wasi::RIGHTS_FD_WRITE | wasi::RIGHTS_PATH_FILESTAT_GET,
|
|
0,
|
|
// Pass some flags for later retrieval
|
|
wasi::FDFLAGS_APPEND | wasi::FDFLAGS_SYNC,
|
|
)
|
|
.expect("opening a file");
|
|
assert_gt!(
|
|
file_fd,
|
|
libc::STDERR_FILENO as wasi::Fd,
|
|
"file descriptor range check",
|
|
);
|
|
|
|
fdstat = wasi::fd_fdstat_get(file_fd).expect("fd_fdstat_get");
|
|
assert_eq!(
|
|
fdstat.fs_rights_base & wasi::RIGHTS_PATH_FILESTAT_GET,
|
|
0,
|
|
"files shouldn't have rights for path_* syscalls even if manually given",
|
|
);
|
|
assert_eq!(
|
|
fdstat.fs_rights_inheriting & wasi::RIGHTS_PATH_FILESTAT_GET,
|
|
0,
|
|
"files shouldn't have rights for path_* syscalls even if manually given",
|
|
);
|
|
assert_ne!(
|
|
fdstat.fs_flags & (wasi::FDFLAGS_APPEND | wasi::FDFLAGS_SYNC),
|
|
0,
|
|
"file should have the same flags used to create the file"
|
|
);
|
|
|
|
// Check file size
|
|
let mut stat = wasi::path_filestat_get(dir_fd, 0, "file").expect("reading file stats");
|
|
assert_eq!(stat.size, 0, "file size should be 0");
|
|
|
|
// Check path_filestat_set_times
|
|
let new_mtim = stat.mtim - 100;
|
|
wasi::path_filestat_set_times(dir_fd, 0, "file", 0, new_mtim, wasi::FSTFLAGS_MTIM)
|
|
.expect("path_filestat_set_times should succeed");
|
|
|
|
stat = wasi::path_filestat_get(dir_fd, 0, "file")
|
|
.expect("reading file stats after path_filestat_set_times");
|
|
assert_eq!(stat.mtim, new_mtim, "mtim should change");
|
|
|
|
assert_eq!(
|
|
wasi::path_filestat_set_times(
|
|
dir_fd,
|
|
0,
|
|
"file",
|
|
0,
|
|
new_mtim,
|
|
wasi::FSTFLAGS_MTIM | wasi::FSTFLAGS_MTIM_NOW,
|
|
)
|
|
.expect_err("MTIM and MTIM_NOW can't both be set")
|
|
.raw_error(),
|
|
wasi::ERRNO_INVAL,
|
|
"errno should be ERRNO_INVAL"
|
|
);
|
|
|
|
// check if the times were untouched
|
|
stat = wasi::path_filestat_get(dir_fd, 0, "file")
|
|
.expect("reading file stats after ERRNO_INVAL fd_filestat_set_times");
|
|
assert_eq!(stat.mtim, new_mtim, "mtim should not change");
|
|
|
|
assert_eq!(
|
|
wasi::path_filestat_set_times(
|
|
dir_fd,
|
|
0,
|
|
"file",
|
|
0,
|
|
0,
|
|
wasi::FSTFLAGS_ATIM | wasi::FSTFLAGS_ATIM_NOW,
|
|
)
|
|
.expect_err("ATIM & ATIM_NOW can't both be set")
|
|
.raw_error(),
|
|
wasi::ERRNO_INVAL,
|
|
"errno should be ERRNO_INVAL"
|
|
);
|
|
|
|
// Create a symlink
|
|
wasi::path_symlink("file", dir_fd, "symlink").expect("creating symlink to a file");
|
|
|
|
// Check path_filestat_set_times on the symlink itself
|
|
let mut sym_stat = wasi::path_filestat_get(dir_fd, 0, "file").expect("reading file stats");
|
|
|
|
let sym_new_mtim = sym_stat.mtim - 200;
|
|
wasi::path_filestat_set_times(dir_fd, 0, "symlink", 0, sym_new_mtim, wasi::FSTFLAGS_MTIM)
|
|
.expect("path_filestat_set_times should succeed on symlink");
|
|
|
|
sym_stat = wasi::path_filestat_get(dir_fd, 0, "symlink")
|
|
.expect("reading file stats after path_filestat_set_times");
|
|
assert_eq!(sym_stat.mtim, sym_new_mtim, "mtim should change");
|
|
|
|
// Now, dereference the symlink
|
|
sym_stat = wasi::path_filestat_get(dir_fd, wasi::LOOKUPFLAGS_SYMLINK_FOLLOW, "symlink")
|
|
.expect("reading file stats on the dereferenced symlink");
|
|
assert_eq!(
|
|
sym_stat.mtim, stat.mtim,
|
|
"symlink mtim should be equal to pointee's when dereferenced"
|
|
);
|
|
|
|
// Finally, change stat of the original file by dereferencing the symlink
|
|
wasi::path_filestat_set_times(
|
|
dir_fd,
|
|
wasi::LOOKUPFLAGS_SYMLINK_FOLLOW,
|
|
"symlink",
|
|
0,
|
|
sym_stat.mtim,
|
|
wasi::FSTFLAGS_MTIM,
|
|
)
|
|
.expect("path_filestat_set_times should succeed on setting stat on original file");
|
|
|
|
stat = wasi::path_filestat_get(dir_fd, 0, "file")
|
|
.expect("reading file stats after path_filestat_set_times");
|
|
assert_eq!(stat.mtim, sym_stat.mtim, "mtim should change");
|
|
|
|
wasi::fd_close(file_fd).expect("closing a file");
|
|
wasi::path_unlink_file(dir_fd, "file").expect("removing a file");
|
|
wasi::path_unlink_file(dir_fd, "symlink").expect("removing a symlink");
|
|
}
|
|
fn main() {
|
|
let mut args = env::args();
|
|
let prog = args.next().unwrap();
|
|
let arg = if let Some(arg) = args.next() {
|
|
arg
|
|
} else {
|
|
eprintln!("usage: {} <scratch directory>", prog);
|
|
process::exit(1);
|
|
};
|
|
|
|
// Open scratch directory
|
|
let dir_fd = match open_scratch_directory(&arg) {
|
|
Ok(dir_fd) => dir_fd,
|
|
Err(err) => {
|
|
eprintln!("{}", err);
|
|
process::exit(1)
|
|
}
|
|
};
|
|
|
|
// Run the tests.
|
|
unsafe { test_path_filestat(dir_fd) }
|
|
}
|