00f357c028
* Cranelift: make `ir::Type` a `u16`.
* Cranelift: pack ValueData back into 64 bits.
After extending `Type` to a `u16`, `ValueData` became 12 bytes rather
than 8. This packs it back down to 8 bytes (64 bits) by stealing two
bits from the `Type` for the enum discriminant (leaving 14 bits for the
type itself).
Performance comparison (3-way between original (`ty-u8`), 16-bit `Type`
(`ty-u16`), and this PR (`ty-packed`)):
```
~/work/sightglass% target/release/sightglass-cli benchmark \
-e ~/ty-u8.so -e ~/ty-u16.so -e ~/ty-packed.so \
--iterations-per-process 10 --processes 2 \
benchmarks-next/spidermonkey/benchmark.wasm
compilation
benchmarks-next/spidermonkey/benchmark.wasm
cycles
[20654406874 21749213920.50 22958520306] /home/cfallin/ty-packed.so
[22227738316 22584704883.90 22916433748] /home/cfallin/ty-u16.so
[20659150490 21598675968.60 22588108428] /home/cfallin/ty-u8.so
nanoseconds
[5435333269 5723139427.25 6041072883] /home/cfallin/ty-packed.so
[5848788229 5942729637.85 6030030341] /home/cfallin/ty-u16.so
[5436002390 5683248226.10 5943626225] /home/cfallin/ty-u8.so
```
So, when compiling SpiderMonkey.wasm, making `Type` 16 bits regresses
performance by 4.5% (5.683s -> 5.723s), while this PR gets 14 bits for a 1.0%
cost (5.683s -> 5.723s). That's still not great, and we can likely do better,
but it's a start.
* Fix test failure: entities to/from u32 via `{from,to}_bits`, not `{from,to}_u32`.
This crate contains array-based data structures used by the core Cranelift code generator which use densely numbered entity references as mapping keys.
One major difference between this crate and crates like slotmap, slab, and generational-arena is that this crate currently provides no way to delete entities. This limits its use to situations where deleting isn't important, however this also makes it more efficient, because it doesn't need extra bookkeeping state to reuse the storage for deleted objects, or to ensure that new objects always have unique keys (eg. slotmap's and generational-arena's versioning).
Another major difference is that this crate protects against using a key from
one map to access an element in another. Where SlotMap, Slab, and Arena
have a value type parameter, PrimaryMap has a key type parameter and a value
type parameter. The crate also provides the entity_impl macro which makes it
easy to declare new unique types for use as keys. Any attempt to use a key in
a map it's not intended for is diagnosed with a type error.
Another is that this crate has two core map types, PrimaryMap and
SecondaryMap, which serve complementary purposes. A PrimaryMap creates its
own keys when elements are inserted, while an SecondaryMap reuses the keys
values of a PrimaryMap, conceptually storing additional data in the same
index space. SecondaryMap's values must implement Default and all elements
in an SecondaryMap initially have the value of default().
A common way to implement Default is to wrap a type in Option, however
this crate also provides the PackedOption utility which can use less memory
in some cases.
Additional utilities provided by this crate include:
EntityList, for allocating many small arrays (such as instruction operand lists in a compiler code generator).SparseMap: an alternative toSecondaryMapwhich can use less memory in some situations.EntitySet: a specialized form ofSecondaryMapusing a bitvector to record which entities are members of the set.