* Add `*_unchecked` variants of `Func` APIs for the C API This commit is what is hopefully going to be my last installment within the saga of optimizing function calls in/out of WebAssembly modules in the C API. This is yet another alternative approach to #3345 (sorry) but also contains everything necessary to make the C API fast. As in #3345 the general idea is just moving checks out of the call path in the same style of `TypedFunc`. This new strategy takes inspiration from previously learned attempts effectively "just" exposes how we previously passed `*mut u128` through trampolines for arguments/results. This storage format is formalized through a new `ValRaw` union that is exposed from the `wasmtime` crate. By doing this it made it relatively easy to expose two new APIs: * `Func::new_unchecked` * `Func::call_unchecked` These are the same as their checked equivalents except that they're `unsafe` and they work with `*mut ValRaw` rather than safe slices of `Val`. Working with these eschews type checks and such and requires callers/embedders to do the right thing. These two new functions are then exposed via the C API with new functions, enabling C to have a fast-path of calling/defining functions. This fast path is akin to `Func::wrap` in Rust, although that API can't be built in C due to C not having generics in the same way that Rust has. For some benchmarks, the benchmarks here are: * `nop` - Call a wasm function from the host that does nothing and returns nothing. * `i64` - Call a wasm function from the host, the wasm function calls a host function, and the host function returns an `i64` all the way out to the original caller. * `many` - Call a wasm function from the host, the wasm calls host function with 5 `i32` parameters, and then an `i64` result is returned back to the original host * `i64` host - just the overhead of the wasm calling the host, so the wasm calls the host function in a loop. * `many` host - same as `i64` host, but calling the `many` host function. All numbers in this table are in nanoseconds, and this is just one measurement as well so there's bound to be some variation in the precise numbers here. | Name | Rust | C (before) | C (after) | |-----------|------|------------|-----------| | nop | 19 | 112 | 25 | | i64 | 22 | 207 | 32 | | many | 27 | 189 | 34 | | i64 host | 2 | 38 | 5 | | many host | 7 | 75 | 8 | The main conclusion here is that the C API is significantly faster than before when using the `*_unchecked` variants of APIs. The Rust implementation is still the ceiling (or floor I guess?) for performance The main reason that C is slower than Rust is that a little bit more has to travel through memory where on the Rust side of things we can monomorphize and inline a bit more to get rid of that. Overall though the costs are way way down from where they were originally and I don't plan on doing a whole lot more myself at this time. There's various things we theoretically could do I've considered but implementation-wise I think they'll be much more weighty. * Tweak `wasmtime_externref_t` API comments
192 lines
5.5 KiB
Rust
192 lines
5.5 KiB
Rust
use crate::{
|
|
bad_utf8, handle_result, wasm_engine_t, wasm_functype_t, wasm_trap_t, wasmtime_error_t,
|
|
wasmtime_extern_t, wasmtime_module_t, CStoreContextMut,
|
|
};
|
|
use std::ffi::c_void;
|
|
use std::mem::MaybeUninit;
|
|
use std::str;
|
|
use wasmtime::{Func, Instance, Linker};
|
|
|
|
#[repr(C)]
|
|
pub struct wasmtime_linker_t {
|
|
linker: Linker<crate::StoreData>,
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_linker_new(engine: &wasm_engine_t) -> Box<wasmtime_linker_t> {
|
|
Box::new(wasmtime_linker_t {
|
|
linker: Linker::new(&engine.engine),
|
|
})
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_linker_allow_shadowing(
|
|
linker: &mut wasmtime_linker_t,
|
|
allow_shadowing: bool,
|
|
) {
|
|
linker.linker.allow_shadowing(allow_shadowing);
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_linker_delete(_linker: Box<wasmtime_linker_t>) {}
|
|
|
|
macro_rules! to_str {
|
|
($ptr:expr, $len:expr) => {
|
|
match str::from_utf8(crate::slice_from_raw_parts($ptr, $len)) {
|
|
Ok(s) => s,
|
|
Err(_) => return bad_utf8(),
|
|
}
|
|
};
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_define(
|
|
linker: &mut wasmtime_linker_t,
|
|
module: *const u8,
|
|
module_len: usize,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
item: &wasmtime_extern_t,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let linker = &mut linker.linker;
|
|
let module = to_str!(module, module_len);
|
|
let name = to_str!(name, name_len);
|
|
let item = item.to_extern();
|
|
handle_result(linker.define(module, name, item), |_linker| ())
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_define_func(
|
|
linker: &mut wasmtime_linker_t,
|
|
module: *const u8,
|
|
module_len: usize,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
ty: &wasm_functype_t,
|
|
callback: crate::wasmtime_func_callback_t,
|
|
data: *mut c_void,
|
|
finalizer: Option<extern "C" fn(*mut std::ffi::c_void)>,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let ty = ty.ty().ty.clone();
|
|
let module = to_str!(module, module_len);
|
|
let name = to_str!(name, name_len);
|
|
let cb = crate::func::c_callback_to_rust_fn(callback, data, finalizer);
|
|
handle_result(linker.linker.func_new(module, name, ty, cb), |_linker| ())
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_define_func_unchecked(
|
|
linker: &mut wasmtime_linker_t,
|
|
module: *const u8,
|
|
module_len: usize,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
ty: &wasm_functype_t,
|
|
callback: crate::wasmtime_func_unchecked_callback_t,
|
|
data: *mut c_void,
|
|
finalizer: Option<extern "C" fn(*mut std::ffi::c_void)>,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let ty = ty.ty().ty.clone();
|
|
let module = to_str!(module, module_len);
|
|
let name = to_str!(name, name_len);
|
|
let cb = crate::func::c_unchecked_callback_to_rust_fn(callback, data, finalizer);
|
|
handle_result(
|
|
linker.linker.func_new_unchecked(module, name, ty, cb),
|
|
|_linker| (),
|
|
)
|
|
}
|
|
|
|
#[cfg(feature = "wasi")]
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_linker_define_wasi(
|
|
linker: &mut wasmtime_linker_t,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
handle_result(
|
|
wasmtime_wasi::add_to_linker(&mut linker.linker, |cx| cx.wasi.as_mut().unwrap()),
|
|
|_linker| (),
|
|
)
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_define_instance(
|
|
linker: &mut wasmtime_linker_t,
|
|
store: CStoreContextMut<'_>,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
instance: &Instance,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let linker = &mut linker.linker;
|
|
let name = to_str!(name, name_len);
|
|
handle_result(linker.instance(store, name, *instance), |_linker| ())
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub extern "C" fn wasmtime_linker_instantiate(
|
|
linker: &wasmtime_linker_t,
|
|
store: CStoreContextMut<'_>,
|
|
module: &wasmtime_module_t,
|
|
instance_ptr: &mut Instance,
|
|
trap_ptr: &mut *mut wasm_trap_t,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let result = linker.linker.instantiate(store, &module.module);
|
|
super::instance::handle_instantiate(result, instance_ptr, trap_ptr)
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_module(
|
|
linker: &mut wasmtime_linker_t,
|
|
store: CStoreContextMut<'_>,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
module: &wasmtime_module_t,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let linker = &mut linker.linker;
|
|
let name = to_str!(name, name_len);
|
|
handle_result(linker.module(store, name, &module.module), |_linker| ())
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_get_default(
|
|
linker: &wasmtime_linker_t,
|
|
store: CStoreContextMut<'_>,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
func: &mut Func,
|
|
) -> Option<Box<wasmtime_error_t>> {
|
|
let linker = &linker.linker;
|
|
let name = to_str!(name, name_len);
|
|
handle_result(linker.get_default(store, name), |f| *func = f)
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasmtime_linker_get(
|
|
linker: &wasmtime_linker_t,
|
|
store: CStoreContextMut<'_>,
|
|
module: *const u8,
|
|
module_len: usize,
|
|
name: *const u8,
|
|
name_len: usize,
|
|
item_ptr: &mut MaybeUninit<wasmtime_extern_t>,
|
|
) -> bool {
|
|
let linker = &linker.linker;
|
|
let module = match str::from_utf8(crate::slice_from_raw_parts(module, module_len)) {
|
|
Ok(s) => s,
|
|
Err(_) => return false,
|
|
};
|
|
let name = if name.is_null() {
|
|
None
|
|
} else {
|
|
match str::from_utf8(crate::slice_from_raw_parts(name, name_len)) {
|
|
Ok(s) => Some(s),
|
|
Err(_) => return false,
|
|
}
|
|
};
|
|
match linker.get(store, module, name) {
|
|
Some(which) => {
|
|
crate::initialize(item_ptr, which.into());
|
|
true
|
|
}
|
|
None => false,
|
|
}
|
|
}
|