* Improve wasmi differential fuzzer * Support modules with a `start` function * Implement trap-matching to ensure that wasmi and Wasmtime both report the same flavor of trap. * Support differential fuzzing where no engines match Locally I was attempting to run against just one wasm engine with `ALLOWED_ENGINES=wasmi` but the fuzzer quickly panicked because the generated test case didn't match wasmi's configuration. This commit updates engine-selection in the differential fuzzer to return `None` if no engine is applicable, throwing out the test case. This won't be hit at all with oss-fuzz-based runs but for local runs it'll be useful to have. * Improve proposal support in differential fuzzer * De-prioritize unstable wasm proposals such as multi-memory and memory64 by making them more unlikely with `Unstructured::ratio`. * Allow fuzzing multi-table (reference types) and multi-memory by avoiding setting their maximums to 1 in `set_differential_config`. * Update selection of the pooling strategy to unconditionally support the selected module config rather than the other way around. * Improve handling of traps in differential fuzzing This commit fixes an issue found via local fuzzing where engines were reporting different results but the underlying reason for this was that one engine was hitting stack overflow before the other. To fix the underlying issue I updated the execution to check for stack overflow and, if hit, it discards the entire fuzz test case from then on. The rationale behind this is that each engine can have unique limits for stack overflow. One test case I was looking at for example would stack overflow at less than 1000 frames with epoch interruption enabled but would stack overflow at more than 1000 frames with it disabled. This means that the state after the trap started to diverge and it looked like the engines produced different results. While I was at it I also improved the "function call returned a trap" case to compare traps to make sure the same trap reason popped out. * Fix fuzzer tests
249 lines
9.0 KiB
Rust
249 lines
9.0 KiB
Rust
#![no_main]
|
|
|
|
use libfuzzer_sys::arbitrary::{Result, Unstructured};
|
|
use libfuzzer_sys::fuzz_target;
|
|
use std::sync::atomic::AtomicUsize;
|
|
use std::sync::atomic::Ordering::SeqCst;
|
|
use std::sync::Once;
|
|
use wasmtime::Trap;
|
|
use wasmtime_fuzzing::generators::{Config, DiffValue, DiffValueType, SingleInstModule};
|
|
use wasmtime_fuzzing::oracles::diff_wasmtime::WasmtimeInstance;
|
|
use wasmtime_fuzzing::oracles::engine::{build_allowed_env_list, parse_env_list};
|
|
use wasmtime_fuzzing::oracles::{differential, engine, log_wasm};
|
|
|
|
// Upper limit on the number of invocations for each WebAssembly function
|
|
// executed by this fuzz target.
|
|
const NUM_INVOCATIONS: usize = 5;
|
|
|
|
// Only run once when the fuzz target loads.
|
|
static SETUP: Once = Once::new();
|
|
|
|
// Environment-specified configuration for controlling the kinds of engines and
|
|
// modules used by this fuzz target. E.g.:
|
|
// - ALLOWED_ENGINES=wasmi,spec cargo +nightly fuzz run ...
|
|
// - ALLOWED_ENGINES=-v8 cargo +nightly fuzz run ...
|
|
// - ALLOWED_MODULES=single-inst cargo +nightly fuzz run ...
|
|
static mut ALLOWED_ENGINES: Vec<&str> = vec![];
|
|
static mut ALLOWED_MODULES: Vec<&str> = vec![];
|
|
|
|
// Statistics about what's actually getting executed during fuzzing
|
|
static STATS: RuntimeStats = RuntimeStats::new();
|
|
|
|
fuzz_target!(|data: &[u8]| {
|
|
SETUP.call_once(|| {
|
|
// To avoid a uncaught `SIGSEGV` due to signal handlers; see comments on
|
|
// `setup_ocaml_runtime`.
|
|
engine::setup_engine_runtimes();
|
|
|
|
// Retrieve the configuration for this fuzz target from `ALLOWED_*`
|
|
// environment variables.
|
|
let allowed_engines = build_allowed_env_list(
|
|
parse_env_list("ALLOWED_ENGINES"),
|
|
&["wasmtime", "wasmi", "spec", "v8"],
|
|
);
|
|
let allowed_modules = build_allowed_env_list(
|
|
parse_env_list("ALLOWED_MODULES"),
|
|
&["wasm-smith", "single-inst"],
|
|
);
|
|
unsafe {
|
|
ALLOWED_ENGINES = allowed_engines;
|
|
ALLOWED_MODULES = allowed_modules;
|
|
}
|
|
});
|
|
|
|
// Errors in `run` have to do with not enough input in `data`, which we
|
|
// ignore here since it doesn't affect how we'd like to fuzz.
|
|
drop(run(&data));
|
|
});
|
|
|
|
fn run(data: &[u8]) -> Result<()> {
|
|
STATS.bump_attempts();
|
|
|
|
let mut u = Unstructured::new(data);
|
|
let mut config: Config = u.arbitrary()?;
|
|
config.set_differential_config();
|
|
|
|
// Generate the Wasm module; this is specified by either the ALLOWED_MODULES
|
|
// environment variable or a random selection between wasm-smith and
|
|
// single-inst.
|
|
let build_wasm_smith_module = |u: &mut Unstructured, config: &mut Config| -> Result<_> {
|
|
STATS.wasm_smith_modules.fetch_add(1, SeqCst);
|
|
let module = config.generate(u, Some(1000))?;
|
|
Ok(module.to_bytes())
|
|
};
|
|
let build_single_inst_module = |u: &mut Unstructured, config: &mut Config| -> Result<_> {
|
|
STATS.single_instruction_modules.fetch_add(1, SeqCst);
|
|
let module = SingleInstModule::new(u, &mut config.module_config)?;
|
|
Ok(module.to_bytes())
|
|
};
|
|
if unsafe { ALLOWED_MODULES.is_empty() } {
|
|
panic!("unable to generate a module to fuzz against; check `ALLOWED_MODULES`")
|
|
}
|
|
let wasm = match *u.choose(unsafe { ALLOWED_MODULES.as_slice() })? {
|
|
"wasm-smith" => build_wasm_smith_module(&mut u, &mut config)?,
|
|
"single-inst" => build_single_inst_module(&mut u, &mut config)?,
|
|
_ => unreachable!(),
|
|
};
|
|
log_wasm(&wasm);
|
|
|
|
// Choose a left-hand side Wasm engine. If no engine could be chosen then
|
|
// that means the configuration selected above doesn't match any allowed
|
|
// engine (configured via an env var) so the test case is thrown out.
|
|
let mut lhs = match engine::choose(&mut u, &config, unsafe { &ALLOWED_ENGINES })? {
|
|
Some(engine) => engine,
|
|
None => return Ok(()),
|
|
};
|
|
let lhs_instance = lhs.instantiate(&wasm);
|
|
STATS.bump_engine(lhs.name());
|
|
|
|
// Choose a right-hand side Wasm engine--this will always be Wasmtime.
|
|
let rhs_store = config.to_store();
|
|
let rhs_module = wasmtime::Module::new(rhs_store.engine(), &wasm).unwrap();
|
|
let rhs_instance = WasmtimeInstance::new(rhs_store, rhs_module);
|
|
|
|
// If we fail to instantiate, check that both sides do.
|
|
let (mut lhs_instance, mut rhs_instance) = match (lhs_instance, rhs_instance) {
|
|
(Ok(l), Ok(r)) => (l, r),
|
|
(Err(l), Err(r)) => {
|
|
let err = r.downcast::<Trap>().expect("not a trap");
|
|
lhs.assert_error_match(&err, &l);
|
|
return Ok(());
|
|
}
|
|
(l, r) => panic!(
|
|
"failed to instantiate only one side: {:?} != {:?}",
|
|
l.err(),
|
|
r.err()
|
|
),
|
|
};
|
|
|
|
// Call each exported function with different sets of arguments.
|
|
'outer: for (name, signature) in rhs_instance.exported_functions() {
|
|
let mut invocations = 0;
|
|
loop {
|
|
let arguments = signature
|
|
.params()
|
|
.map(|t| DiffValue::arbitrary_of_type(&mut u, t.try_into().unwrap()))
|
|
.collect::<Result<Vec<_>>>()?;
|
|
let result_tys = signature
|
|
.results()
|
|
.map(|t| DiffValueType::try_from(t).unwrap())
|
|
.collect::<Vec<_>>();
|
|
let ok = differential(
|
|
lhs_instance.as_mut(),
|
|
lhs.as_ref(),
|
|
&mut rhs_instance,
|
|
&name,
|
|
&arguments,
|
|
&result_tys,
|
|
)
|
|
.expect("failed to run differential evaluation");
|
|
|
|
invocations += 1;
|
|
STATS.total_invocations.fetch_add(1, SeqCst);
|
|
|
|
// If this differential execution has resulted in the two instances
|
|
// diverging in state we can't keep executing so don't execute any
|
|
// more functions.
|
|
if !ok {
|
|
break 'outer;
|
|
}
|
|
|
|
// We evaluate the same function with different arguments until we
|
|
// hit a predetermined limit or we run out of unstructured data--it
|
|
// does not make sense to re-evaluate the same arguments over and
|
|
// over.
|
|
if invocations > NUM_INVOCATIONS || u.is_empty() {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
STATS.successes.fetch_add(1, SeqCst);
|
|
Ok(())
|
|
}
|
|
|
|
#[derive(Default)]
|
|
struct RuntimeStats {
|
|
/// Total number of fuzz inputs processed
|
|
attempts: AtomicUsize,
|
|
|
|
/// Number of times we've invoked engines
|
|
total_invocations: AtomicUsize,
|
|
|
|
/// Number of times a fuzz input finished all the way to the end without any
|
|
/// sort of error (including `Arbitrary` errors)
|
|
successes: AtomicUsize,
|
|
|
|
// Counters for which engine was chosen
|
|
wasmi: AtomicUsize,
|
|
v8: AtomicUsize,
|
|
spec: AtomicUsize,
|
|
wasmtime: AtomicUsize,
|
|
|
|
// Counters for which style of module is chosen
|
|
wasm_smith_modules: AtomicUsize,
|
|
single_instruction_modules: AtomicUsize,
|
|
}
|
|
|
|
impl RuntimeStats {
|
|
const fn new() -> RuntimeStats {
|
|
RuntimeStats {
|
|
attempts: AtomicUsize::new(0),
|
|
total_invocations: AtomicUsize::new(0),
|
|
successes: AtomicUsize::new(0),
|
|
wasmi: AtomicUsize::new(0),
|
|
v8: AtomicUsize::new(0),
|
|
spec: AtomicUsize::new(0),
|
|
wasmtime: AtomicUsize::new(0),
|
|
wasm_smith_modules: AtomicUsize::new(0),
|
|
single_instruction_modules: AtomicUsize::new(0),
|
|
}
|
|
}
|
|
|
|
fn bump_attempts(&self) {
|
|
let attempts = self.attempts.fetch_add(1, SeqCst);
|
|
if attempts == 0 || attempts % 1_000 != 0 {
|
|
return;
|
|
}
|
|
let successes = self.successes.load(SeqCst);
|
|
println!(
|
|
"=== Execution rate ({} successes / {} attempted modules): {:.02}% ===",
|
|
successes,
|
|
attempts,
|
|
successes as f64 / attempts as f64 * 100f64,
|
|
);
|
|
|
|
let v8 = self.v8.load(SeqCst);
|
|
let spec = self.spec.load(SeqCst);
|
|
let wasmi = self.wasmi.load(SeqCst);
|
|
let wasmtime = self.wasmtime.load(SeqCst);
|
|
let total = v8 + spec + wasmi + wasmtime;
|
|
println!(
|
|
"\twasmi: {:.02}%, spec: {:.02}%, wasmtime: {:.02}%, v8: {:.02}%",
|
|
wasmi as f64 / total as f64 * 100f64,
|
|
spec as f64 / total as f64 * 100f64,
|
|
wasmtime as f64 / total as f64 * 100f64,
|
|
v8 as f64 / total as f64 * 100f64,
|
|
);
|
|
|
|
let wasm_smith = self.wasm_smith_modules.load(SeqCst);
|
|
let single_inst = self.single_instruction_modules.load(SeqCst);
|
|
let total = wasm_smith + single_inst;
|
|
println!(
|
|
"\twasm-smith: {:.02}%, single-inst: {:.02}%",
|
|
wasm_smith as f64 / total as f64 * 100f64,
|
|
single_inst as f64 / total as f64 * 100f64,
|
|
);
|
|
}
|
|
|
|
fn bump_engine(&self, name: &str) {
|
|
match name {
|
|
"wasmi" => self.wasmi.fetch_add(1, SeqCst),
|
|
"wasmtime" => self.wasmtime.fetch_add(1, SeqCst),
|
|
"spec" => self.spec.fetch_add(1, SeqCst),
|
|
"v8" => self.v8.fetch_add(1, SeqCst),
|
|
_ => return,
|
|
};
|
|
}
|
|
}
|