T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect assertion for insertlane (#1355)

Browse Source 
Previously, the assertion checked for `lane > 0` when it should have been `lane >= 0`; since lane is unsigned, this half of the assertion can be entirely removed.
This commit is contained in:
Andrew Brown
2020-01-17 14:39:31 -08:00
committed by GitHub
parent 80d11e3f8d
commit fd04ea2b06
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cranelift/codegen/src/isa/x86/enc_tables.rs
View File

@@ -1173,7 +1173,7 @@ fn convert_insertlane(
// Floats are already in XMM registers and can stay there. // Floats are already in XMM registers and can stay there.
match value_type { match value_type {
F32X4 => { F32X4 => {
assert!(lane > 0 && lane <= 3); assert!(lane <= 3);
let immediate = 0b00_00_00_00 | lane << 4; let immediate = 0b00_00_00_00 | lane << 4;
// Insert 32-bits from replacement (at index 00, bits 7:8) to vector (lane // Insert 32-bits from replacement (at index 00, bits 7:8) to vector (lane
// shifted into bits 5:6). // shifted into bits 5:6).