T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make vconst BxN match specification

Browse Source
This commit is contained in:
teapotd
2020-05-27 17:14:54 +02:00
committed by Andrew Brown
parent 628a9f0eaa
commit fbac2e53f9
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cranelift/filetests/filetests/isa/x86/simd-vconst-rodata.clif
View File

@@ -16,7 +16,7 @@ block0:
return v0
}
; sameln: [1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 1, 0]
; sameln: [FF, FF, 0, 0, FF, FF, 0, 0, FF, FF, 0, 0, FF, FF, FF, FF]
; Since both jump tables and constants are emitted after the function body, it is important that they do not interfere.

7
cranelift/reader/src/parser.rs
View File

@@ -1075,9 +1075,8 @@ impl<'a> Parser<'a> {
if lane_size < 1 {
panic!("The boolean lane must have a byte size greater than zero.");
}
let mut buffer = vec![0; lane_size as usize];
buffer[0] = if value { 1 } else { 0 };
buffer
let value = if value { 0xFF } else { 0 };
vec![value; lane_size as usize]
}
if !ty.is_vector() {
@@ -3824,7 +3823,7 @@ mod tests {
.unwrap();
assert_eq!(
c.into_vec(),
[1, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0]
[0xFF, 0xFF, 0xFF, 0xFF, 0, 0, 0, 0, 0xFF, 0xFF, 0xFF, 0xFF, 0, 0, 0, 0]
)
}