T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Assert that we only use virtual registers with moves (#5440)

Browse Source 
Assert that we never see real registers as arguments to move instructions in VCodeBuilder::collect_operands.

Also fix a bug in the riscv64 backend that was discovered by these assertions: the lowerings of get_stack_pointer and get_frame_pointer were using physical registers 8 and 2 directly. The solution was similar to other backends: add a move instruction specifically for moving out of physical registers, whose source operand is opaque to regalloc2.
This commit is contained in:
Trevor Elliott
2022-12-20 18:22:47 -08:00
committed by GitHub
parent a308828ba2
commit fac4a915a3
6 changed files with 71 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cranelift/codegen/src/isa/riscv64/lower.isle
View File

@@ -858,10 +858,10 @@
;;; Rules for `get_{frame,stack}_pointer` and `get_return_address` ;;;;;;;;;;;;;
(rule (lower (get_frame_pointer))
(gen_move2 (x_reg 8) $I64 $I64))
(gen_mov_from_preg (fp_reg)))
(rule (lower (get_stack_pointer))
(gen_move2 (x_reg 2) $I64 $I64))
(gen_mov_from_preg (sp_reg)))
(rule (lower (get_return_address))
(load_ra))