Check the types of values returned by Callable (#876)

If the values mismatch to the ones that were specified by the
signature of the callable, raise a trap!
This commit is contained in:
Sergei Pepyakin
2020-01-30 21:11:41 +01:00
committed by GitHub
parent eb183d7ab3
commit f2382db461
2 changed files with 58 additions and 1 deletions

View File

@@ -64,3 +64,53 @@ fn test_import_calling_export() {
run_func.call(&[]).expect("expected function not to trap");
}
#[test]
fn test_returns_incorrect_type() {
const WAT: &str = r#"
(module
(import "env" "evil" (func $evil (result i32)))
(func (export "run") (result i32)
(call $evil)
)
)
"#;
struct EvilCallback;
impl Callable for EvilCallback {
fn call(&self, _params: &[Val], results: &mut [Val]) -> Result<(), Trap> {
// Evil! Returns I64 here instead of promised in the signature I32.
results[0] = Val::I64(228);
Ok(())
}
}
let store = Store::default();
let module = Module::new(&store, WAT).expect("failed to create module");
let callback = Rc::new(EvilCallback);
let callback_func = Func::new(
&store,
FuncType::new(Box::new([]), Box::new([ValType::I32])),
callback.clone(),
);
let imports = vec![callback_func.into()];
let instance =
Instance::new(&module, imports.as_slice()).expect("failed to instantiate module");
let exports = instance.exports();
assert!(!exports.is_empty());
let run_func = exports[0]
.func()
.expect("expected a run func in the module");
let trap = run_func.call(&[]).expect_err("the execution should fail");
assert_eq!(
trap.message(),
"`Callable` attempted to return an incompatible value"
);
}