T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

peepmatic: Be generic over the operator type

Browse Source 
This lets us avoid the cost of `cranelift_codegen::ir::Opcode` to
`peepmatic_runtime::Operator` conversion overhead, and paves the way for
allowing Peepmatic to support non-clif optimizations (e.g. vcode optimizations).

Rather than defining our own `peepmatic::Operator` type like we used to, now the
whole `peepmatic` crate is effectively generic over a `TOperator` type
parameter. For the Cranelift integration, we use `cranelift_codegen::ir::Opcode`
as the concrete type for our `TOperator` type parameter. For testing, we also
define a `TestOperator` type, so that we can test Peepmatic code without
building all of Cranelift, and we can keep them somewhat isolated from each
other.

The methods that `peepmatic::Operator` had are now translated into trait bounds
on the `TOperator` type. These traits need to be shared between all of
`peepmatic`, `peepmatic-runtime`, and `cranelift-codegen`'s Peepmatic
integration. Therefore, these new traits live in a new crate:
`peepmatic-traits`. This crate acts as a header file of sorts for shared
trait/type/macro definitions.

Additionally, the `peepmatic-runtime` crate no longer depends on the
`peepmatic-macro` procedural macro crate, which should lead to faster build
times for Cranelift when it is using pre-built peephole optimizers.
This commit is contained in:
Nick Fitzgerald
2020-06-30 11:50:10 -07:00
parent ae95ad8733
commit ee5982fd16
46 changed files with 1945 additions and 1387 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cranelift/peepmatic/Cargo.toml
View File

@@ -10,8 +10,13 @@ description = "DSL and compiler for generating peephole optimizers"
[dependencies]
anyhow = "1.0.27"
peepmatic-automata = { version = "0.2.0", path = "crates/automata", features = ["dot"] }
peepmatic-macro = { version = "0.2.0", path = "crates/macro" }
peepmatic-runtime = { version = "0.2.0", path = "crates/runtime", features = ["construct"] }
peepmatic-automata = { version = "0.66.0", path = "crates/automata", features = ["dot"] }
peepmatic-macro = { version = "0.66.0", path = "crates/macro" }
peepmatic-runtime = { version = "0.66.0", path = "crates/runtime", features = ["construct"] }
peepmatic-traits = { version = "0.66.0", path = "crates/traits" }
serde = { version = "1.0.105", features = ["derive"] }
wast = "15.0.0"
z3 = { version = "0.6.0", features = ["static-link-z3"] }
[dev-dependencies]
peepmatic-test-operator = { version = "0.66.0", path = "crates/test-operator" }