T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wasmtime: Add lots of logging for externrefs and table_ops fuzz target (#4583)

Browse Source 
I essentially add these same logs back in every time I'm debugging something
related to this fuzz target or `externref`s in general. Probably like 5 times
I've added roughly these logs. We should just make them available whenever we
need them via `RUST_LOG=wasmtime_runtime=trace`.

This also changes a couple `if let`s to `unwrap`s that are now infallible after
This commit is contained in:
Nick Fitzgerald
2022-08-02 15:06:44 -07:00
committed by GitHub
parent 42bba452a6
commit edf7f9f2bb
4 changed files with 93 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/runtime/src/traphandlers/backtrace.rs
View File

@@ -198,7 +198,7 @@ impl Backtrace {
// contiguous sequence of Wasm frames, and we have nothing to
// walk through here.
if first_wasm_sp == -1_isize as usize {
log::trace!("Empty sequence of Wasm frames");
log::trace!("=== Done tracing (empty sequence of Wasm frames) ===");
return ControlFlow::Continue(());
}
@@ -224,8 +224,8 @@ impl Backtrace {
arch::assert_fp_is_aligned(fp);
log::trace!("--- Tracing through one Wasm frame ---");
log::trace!("pc = 0x{:016x}", pc);
log::trace!("fp = 0x{:016x}", fp);
log::trace!("pc = {:p}", pc as *const ());
log::trace!("fp = {:p}", fp as *const ());
f(Frame { pc, fp })?;
@@ -234,6 +234,7 @@ impl Backtrace {
// and have now reached a host frame. We're done iterating
// through this contiguous sequence of Wasm frames.
if arch::reached_entry_sp(fp, first_wasm_sp) {
log::trace!("=== Done tracing contiguous sequence of Wasm frames ===");
return ControlFlow::Continue(());
}