T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add assertions to check translate_call and translate_call_indirect.

Browse Source 
Assert that the results produced by translate_call and
translate_call_indirect match the results of the call signatures.
This commit is contained in:
Dan Gohman
2018-06-05 09:19:08 -07:00
parent 4e64fc11c9
commit eb94664285
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/wasm/src/code_translator.rs
View File

@@ -361,8 +361,16 @@ pub fn translate_operator<FE: FuncEnvironment + ?Sized>(
fref, fref,
state.peekn(num_args), state.peekn(num_args),
)?; )?;
let inst_results = builder.inst_results(call);
debug_assert_eq!(
inst_results.len(),
builder.func.dfg.signatures[builder.func.dfg.ext_funcs[fref].signature]
.returns
.len(),
"translate_call results should match the call signature"
);
state.popn(num_args); state.popn(num_args);
state.pushn(builder.inst_results(call)); state.pushn(inst_results);
} }
Operator::CallIndirect { index, table_index } => { Operator::CallIndirect { index, table_index } => {
// `index` is the index of the function's signature and `table_index` is the index of // `index` is the index of the function's signature and `table_index` is the index of
@@ -377,8 +385,14 @@ pub fn translate_operator<FE: FuncEnvironment + ?Sized>(
callee, callee,
state.peekn(num_args), state.peekn(num_args),
)?; )?;
let inst_results = builder.inst_results(call);
debug_assert_eq!(
inst_results.len(),
builder.func.dfg.signatures[sigref].returns.len(),
"translate_call_indirect results should match the call signature"
);
state.popn(num_args); state.popn(num_args);
state.pushn(builder.inst_results(call)); state.pushn(inst_results);
} }
/******************************* Memory management *********************************** /******************************* Memory management ***********************************
* Memory management is handled by environment. It is usually translated into calls to * Memory management is handled by environment. It is usually translated into calls to