Use InstructionFormat inside InstructionFormatBuilder

cranelift/codegen/meta/src/cdsl/formats.rs

@@ -84,32 +84,26 @@ impl InstructionFormat {
     }
 }
 
-pub(crate) struct InstructionFormatBuilder {
+pub(crate) struct InstructionFormatBuilder(InstructionFormat);
-    name: &'static str,
-    num_value_operands: usize,
-    has_value_list: bool,
-    imm_fields: Vec<FormatField>,
-    typevar_operand: Option<usize>,
-}
 
 impl InstructionFormatBuilder {
     pub fn new(name: &'static str) -> Self {
-        Self {
+        Self(InstructionFormat {
             name,
             num_value_operands: 0,
             has_value_list: false,
             imm_fields: Vec::new(),
             typevar_operand: None,
-        }
+        })
     }
 
     pub fn value(mut self) -> Self {
-        self.num_value_operands += 1;
+        self.0.num_value_operands += 1;
         self
     }
 
     pub fn varargs(mut self) -> Self {
-        self.has_value_list = true;
+        self.0.has_value_list = true;
         self
     }
 
@@ -118,33 +112,23 @@ impl InstructionFormatBuilder {
             kind: operand_kind.clone(),
             member: operand_kind.rust_field_name,
         };
-        self.imm_fields.push(field);
+        self.0.imm_fields.push(field);
         self
     }
 
     pub fn typevar_operand(mut self, operand_index: usize) -> Self {
-        assert!(self.typevar_operand.is_none());
+        assert!(self.0.typevar_operand.is_none());
-        assert!(operand_index < self.num_value_operands);
+        assert!(operand_index < self.0.num_value_operands);
-        self.typevar_operand = Some(operand_index);
+        self.0.typevar_operand = Some(operand_index);
         self
     }
 
-    pub fn build(self) -> Rc<InstructionFormat> {
+    pub fn build(mut self) -> Rc<InstructionFormat> {
-        let typevar_operand = if self.typevar_operand.is_some() {
+        if self.0.typevar_operand.is_none() && self.0.num_value_operands > 0 {
-            self.typevar_operand
-        } else if self.num_value_operands > 0 {
             // Default to the first value operand, if there's one.
-            Some(0)
+            self.0.typevar_operand = Some(0);
-        } else {
-            None
         };
 
-        Rc::new(InstructionFormat {
+        Rc::new(self.0)
-            name: self.name,
-            num_value_operands: self.num_value_operands,
-            has_value_list: self.has_value_list,
-            imm_fields: self.imm_fields,
-            typevar_operand,
-        })
     }
 }

cranelift/codegen/meta/src/cdsl/instructions.rs

@@ -43,7 +43,7 @@ pub(crate) struct InstructionContent {
     /// Output operands. The output operands must be SSA values or `variable_args`.
     pub operands_out: Vec<Operand>,
 
-    /// Instruction format, automatically derived from the input operands.
+    /// Instruction format.
     pub format: Rc<InstructionFormat>,
 
     /// One of the input or output operands is a free type variable. None if the instruction is not