T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

directory seek test: code does not agree with comment. Fix code.

Browse Source 
the directory was opened with the seek right, and this test says that it
was asserting that the seek right was present. However, the test was
actually asserting that the seek right was *not* present.

This fixes the code of the test, because I believe the comment is
correct.
This commit is contained in:
Pat Hickey
2021-01-11 17:57:04 -08:00
parent b1d32f419c
commit d56d2f0219
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/test-programs/wasi-tests/src/bin/directory_seek.rs
View File

@@ -33,7 +33,7 @@ unsafe fn test_directory_seek(dir_fd: wasi::Fd) {
); );
assert_eq!( assert_eq!(
(fdstat.fs_rights_base & wasi::RIGHTS_FD_SEEK), (fdstat.fs_rights_base & wasi::RIGHTS_FD_SEEK),
0, wasi::RIGHTS_FD_SEEK,
"directory has the seek right", "directory has the seek right",
); );

3
crates/wasi-c2/TEST_FAILURES
View File

@@ -16,9 +16,6 @@ wasi_tests::remove_directory_trailing_slashes
- cap-std Dir::remove_dir gives EINVAL when trying to remove dir with - cap-std Dir::remove_dir gives EINVAL when trying to remove dir with
trailing slash. otherwise, everything passes. trailing slash. otherwise, everything passes.
wasi_tests::directory_seek
- something weird about directory open rights / fdstat. need debug
impl of Caps to see about this
wasi_tests::fd_flags_set wasi_tests::fd_flags_set
- set_fdflags is not implemented. test wanted to clear O_APPEND mode - set_fdflags is not implemented. test wanted to clear O_APPEND mode
wasi_tests::path_filestat wasi_tests::path_filestat