From d1be0c18e774fda93225570ab1a1bf979928c993 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Fri, 24 Apr 2020 10:55:50 -0500 Subject: [PATCH] Don't deny warnings on nightly CI (#1589) Too much churn! Closes #1588 --- .github/actions/install-rust/main.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/actions/install-rust/main.js b/.github/actions/install-rust/main.js index 4adf88d4bc..cdc853939b 100644 --- a/.github/actions/install-rust/main.js +++ b/.github/actions/install-rust/main.js @@ -12,8 +12,11 @@ child_process.execFileSync('rustup', ['set', 'profile', 'minimal']); child_process.execFileSync('rustup', ['update', toolchain, '--no-self-update']); child_process.execFileSync('rustup', ['default', toolchain]); -// Deny warnings on CI to keep our code warning-free as it lands in-tree -console.log(`::set-env name=RUSTFLAGS::-D warnings`); +// Deny warnings on CI to keep our code warning-free as it lands in-tree. Don't +// do this on nightly though since there's a fair amount of warning churn there. +if (!toolchain.startsWith('nightly')) { + console.log(`::set-env name=RUSTFLAGS::-D warnings`); +} // Save disk space by avoiding incremental compilation, and also we don't use // any caching so incremental wouldn't help anyway.