From d122d16f79ed2bdc0eb7de0a4b3f7396ad36b543 Mon Sep 17 00:00:00 2001
From: Dan Gohman <sunfish@mozilla.com>
Date: Wed, 18 Apr 2018 10:22:49 -0700
Subject: [PATCH] Style consistency: don't end error messages with exclamation
 points.

---
 lib/codegen/meta/cdsl/isa.py     | 2 +-
 lib/codegen/meta/cdsl/typevar.py | 2 +-
 lib/codegen/src/verifier/mod.rs  | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/codegen/meta/cdsl/isa.py b/lib/codegen/meta/cdsl/isa.py
index 77b071636a..bcff050b1b 100644
--- a/lib/codegen/meta/cdsl/isa.py
+++ b/lib/codegen/meta/cdsl/isa.py
@@ -54,7 +54,7 @@ class TargetISA(object):
         self._predicates = dict()  # type: Dict[PredKey, PredNode]
 
         assert InstructionGroup._current is None,\
-            "InstructionGroup {} is still open!"\
+            "InstructionGroup {} is still open"\
             .format(InstructionGroup._current.name)
 
     def __str__(self):
diff --git a/lib/codegen/meta/cdsl/typevar.py b/lib/codegen/meta/cdsl/typevar.py
index 8cda58785e..d58381529f 100644
--- a/lib/codegen/meta/cdsl/typevar.py
+++ b/lib/codegen/meta/cdsl/typevar.py
@@ -231,7 +231,7 @@ class TypeSet(object):
     def __hash__(self):
         # type: () -> int
         h = hash(self.typeset_key())
-        assert h == getattr(self, 'prev_hash', h), "TypeSet changed!"
+        assert h == getattr(self, 'prev_hash', h), "TypeSet changed"
         self.prev_hash = h
         return h
 
diff --git a/lib/codegen/src/verifier/mod.rs b/lib/codegen/src/verifier/mod.rs
index 28f74699df..66baa5fa91 100644
--- a/lib/codegen/src/verifier/mod.rs
+++ b/lib/codegen/src/verifier/mod.rs
@@ -207,7 +207,7 @@ impl<'a> Verifier<'a> {
             );
         }
         if is_last_inst && !is_terminator {
-            return err!(ebb, "block does not end in a terminator instruction!");
+            return err!(ebb, "block does not end in a terminator instruction");
         }
 
         // Instructions belong to the correct ebb.
@@ -1163,7 +1163,7 @@ mod tests {
     macro_rules! assert_err_with_msg {
         ($e:expr, $msg:expr) => {
             match $e {
-                Ok(_) => panic!("Expected an error!"),
+                Ok(_) => panic!("Expected an error"),
                 Err(Error { message, .. }) => {
                     if !message.contains($msg) {
                         panic!(format!(