T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix github-release action when the dev tag is missing (#6098)

Browse Source 
There was a missing rest field access. In addition createTag doesn't actually create a tag, it creates a tag object. A tag object is an object which references a commit or other kind of object and has various kinds of metadata. You need to store it in a reference stored in refs/tags/ to actually show as tag in the git ui. The code to update the tag however creates a lightweight tag (which is a file in refs/tags/ which directly references a commit rather than a tag object) as such do the same when creating the initial dev tag by using createRef with a commit id as object sha.

See also https://git-scm.com/book/en/v2/Git-Internals-Git-References for the difference between a lightweight tag and an annotated tag.
This commit is contained in:
bjorn3
2023-03-24 16:16:33 +01:00
committed by GitHub
parent 3546ccf7d1
commit d0570a77ce
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.github/actions/github-release/main.js vendored
View File

@@ -57,13 +57,11 @@ async function runOnce() {
console.log("ERROR: ", JSON.stringify(e.data, null, 2)); console.log("ERROR: ", JSON.stringify(e.data, null, 2));
core.info(`creating dev tag`); core.info(`creating dev tag`);
try { try {
await octokit.git.createTag({ await octokit.rest.git.createRef({
owner, owner,
repo, repo,
tag: 'dev', ref: 'refs/tags/dev',
message: 'dev release', sha,
object: sha,
type: 'commit',
}); });
} catch (e) { } catch (e) {
// we might race with others, so assume someone else has created the // we might race with others, so assume someone else has created the