diff --git a/cranelift/codegen/src/isa/x64/mod.rs b/cranelift/codegen/src/isa/x64/mod.rs index fd4444498d..73183f79e8 100644 --- a/cranelift/codegen/src/isa/x64/mod.rs +++ b/cranelift/codegen/src/isa/x64/mod.rs @@ -92,15 +92,15 @@ impl MachBackend for X64Backend { } fn unsigned_add_overflow_condition(&self) -> IntCC { - // Unsigned `>=`; this corresponds to the carry flag set on x86, which happens on - // overflow of an add. - IntCC::UnsignedGreaterThanOrEqual + // Unsigned `<`; this corresponds to the carry flag set on x86, which + // indicates an add has overflowed. + IntCC::UnsignedLessThan } fn unsigned_sub_overflow_condition(&self) -> IntCC { - // unsigned `>=`; this corresponds to the carry flag set on x86, which happens on - // underflow of a subtract (carry is borrow for subtract). - IntCC::UnsignedGreaterThanOrEqual + // unsigned `<`; this corresponds to the carry flag set on x86, which + // indicates a sub has underflowed (carry is borrow for subtract). + IntCC::UnsignedLessThan } #[cfg(feature = "unwind")] diff --git a/cranelift/filetests/filetests/isa/x64/heap.clif b/cranelift/filetests/filetests/isa/x64/heap.clif new file mode 100644 index 0000000000..d9efb083c6 --- /dev/null +++ b/cranelift/filetests/filetests/isa/x64/heap.clif @@ -0,0 +1,23 @@ +test compile +target x86_64 +feature "experimental_x64" + +function %f(i32, i64 vmctx) -> i64 { + gv0 = vmctx + gv1 = load.i64 notrap aligned gv0+0 + gv2 = load.i32 notrap aligned gv0+8 + heap0 = dynamic gv1, bound gv2, offset_guard 0x1000, index_type i32 + +block0(v0: i32, v1: i64): + + v2 = heap_addr.i64 heap0, v0, 0x8000 + ; check: movl 8(%rsi), %r12d + ; nextln: movq %rdi, %r13 + ; nextln: addl $$32768, %r13d + ; nextln: jnb ; ud2 heap_oob ; + ; nextln: cmpl %r12d, %r13d + ; nextln: jbe label1; j label2 + ; check: Block 1: + + return v2 +}