From c810b21488f721e7c97a34c28df278dec30fa032 Mon Sep 17 00:00:00 2001 From: Jakob Stoklund Olesen Date: Wed, 22 Nov 2017 11:48:47 -0800 Subject: [PATCH] Be more forgiving about what's a "slow" test. This was supposed to be Q3 + 1.5 IQR, but a braino meant we actually used Q3 + 2/3 IQR. Since the distribution of test case times is far from gaussian, bump the "slow" limit up even further to Q3 + 3 IQR. --- cranelift/src/filetest/runner.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/cranelift/src/filetest/runner.rs b/cranelift/src/filetest/runner.rs index 8e0f7721a7..320db9d942 100644 --- a/cranelift/src/filetest/runner.rs +++ b/cranelift/src/filetest/runner.rs @@ -302,9 +302,12 @@ impl TestRunner { // Inter-quartile range. let iqr = q3 - q1; - // Cut-off for what we consider a 'slow' test: 1.5 IQR from the 75% quartile. - // These are the data points that would be plotted as outliers outside a box plot. - let cut = q3 + iqr * 2 / 3; + + // Cut-off for what we consider a 'slow' test: 3 IQR from the 75% quartile. + // + // Q3 + 1.5 IQR are the data points that would be plotted as outliers outside a box plot, + // but we have a wider distribution of test times, so double it to 3 IQR. + let cut = q3 + iqr * 3; if cut > *times.last().unwrap() { return; }