T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: implement memory.atomic.notify,wait32,wait64 (#5255)

Browse Source 
* feat: implement memory.atomic.notify,wait32,wait64

Added the parking_spot crate, which provides the needed registry for the
operations.

Signed-off-by: Harald Hoyer <harald@profian.com>

* fix: change trap message for HeapMisaligned

The threads spec test wants "unaligned atomic"
instead of "misaligned memory access".

Signed-off-by: Harald Hoyer <harald@profian.com>

* tests: add test for atomic wait on non-shared memory

Signed-off-by: Harald Hoyer <harald@profian.com>

* tests: add tests/spec_testsuite/proposals/threads

without pooling and reference types.
Also "shared_memory" is added to the "spectest" interface.

Signed-off-by: Harald Hoyer <harald@profian.com>

* tests: add atomics_notify.wast

checking that notify with 0 waiters returns 0 on shared and non-shared
memory.

Signed-off-by: Harald Hoyer <harald@profian.com>

* tests: add tests for atomic wait on shared memory

- return 2 - timeout for 0
- return 2 - timeout for 1000ns
- return 1 - invalid value

Signed-off-by: Harald Hoyer <harald@profian.com>

* fixup! feat: implement memory.atomic.notify,wait32,wait64

Signed-off-by: Harald Hoyer <harald@profian.com>

* fixup! feat: implement memory.atomic.notify,wait32,wait64

Signed-off-by: Harald Hoyer <harald@profian.com>

Signed-off-by: Harald Hoyer <harald@profian.com>
This commit is contained in:
Harald Hoyer
2022-11-21 19:23:06 +01:00
committed by GitHub
parent fe2bfdbc1f
commit c74706aa59
21 changed files with 970 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

97
tests/misc_testsuite/threads/atomics_wait_address.wast
View File

@@ -12,7 +12,7 @@
(export "main" (func $main))
)
(assert_trap (invoke "main") "misaligned memory access")
(assert_trap (invoke "main") "unaligned atomic")
(module
@@ -48,5 +48,96 @@
(export "wait64" (func $wait64))
)
(assert_trap (invoke "wait32") "misaligned memory access")
(assert_trap (invoke "wait64") "misaligned memory access")
(assert_trap (invoke "wait32") "unaligned atomic")
(assert_trap (invoke "wait64") "unaligned atomic")
(module
(type (;0;) (func))
(func $wait32 (type 0)
i32.const 0
i32.const 42
i64.const 0
memory.atomic.wait32
unreachable)
(func $wait64 (type 0)
i32.const 0
i64.const 43
i64.const 0
memory.atomic.wait64
unreachable)
(memory (;0;) 4 4)
(export "wait32" (func $wait32))
(export "wait64" (func $wait64))
)
(assert_trap (invoke "wait32") "atomic wait on non-shared memory")
(assert_trap (invoke "wait64") "atomic wait on non-shared memory")
;; not valid values for memory.atomic.wait
(module
(memory 1 1 shared)
(type (;0;) (func))
(func $wait32 (result i32)
i32.const 0
i32.const 42
i64.const -1
memory.atomic.wait32
)
(func $wait64 (result i32)
i32.const 0
i64.const 43
i64.const -1
memory.atomic.wait64
)
(export "wait32" (func $wait32))
(export "wait64" (func $wait64))
)
(assert_return (invoke "wait32") (i32.const 1))
(assert_return (invoke "wait64") (i32.const 1))
;; timeout
(module
(memory 1 1 shared)
(type (;0;) (func))
(func $wait32 (result i32)
i32.const 0
i32.const 0
i64.const 1000
memory.atomic.wait32
)
(func $wait64 (result i32)
i32.const 0
i64.const 0
i64.const 1000
memory.atomic.wait64
)
(export "wait32" (func $wait32))
(export "wait64" (func $wait64))
)
(assert_return (invoke "wait32") (i32.const 2))
(assert_return (invoke "wait64") (i32.const 2))
;; timeout on 0ns
(module
(memory 1 1 shared)
(type (;0;) (func))
(func $wait32 (result i32)
i32.const 0
i32.const 0
i64.const 0
memory.atomic.wait32
)
(func $wait64 (result i32)
i32.const 0
i64.const 0
i64.const 0
memory.atomic.wait64
)
(export "wait32" (func $wait32))
(export "wait64" (func $wait64))
)
(assert_return (invoke "wait32") (i32.const 2))
(assert_return (invoke "wait64") (i32.const 2))