T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fuzz] Document Wasm-JS conversions (#4683)

Browse Source 
During differential execution against V8, Wasm values need to be
converted back and forth from JS values. This change documents the
location in the specification where this is defined.
This commit is contained in:
Andrew Brown
2022-08-10 16:43:43 -07:00
committed by GitHub
parent 268ddf2f6c
commit c3e31c9946
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/fuzzing/src/oracles/v8.rs
View File

@@ -83,6 +83,8 @@ pub fn differential_v8_execution(wasm: &[u8], config: &crate::generators::Config
ValType::ExternRef => Val::ExternRef(None), ValType::ExternRef => Val::ExternRef(None),
_ => unimplemented!(), _ => unimplemented!(),
}); });
// See https://webassembly.github.io/spec/js-api/index.html#tojsvalue
// for how the Wasm-to-JS conversions are done.
v8_params.push(match param { v8_params.push(match param {
ValType::I32 | ValType::F32 | ValType::F64 => v8::Number::new(&mut scope, 0.0).into(), ValType::I32 | ValType::F32 | ValType::F64 => v8::Number::new(&mut scope, 0.0).into(),
ValType::I64 => v8::BigInt::new_from_i64(&mut scope, 0).into(), ValType::I64 => v8::BigInt::new_from_i64(&mut scope, 0).into(),
@@ -215,6 +217,9 @@ fn eval<'s>(
/// Asserts that the wasmtime value `a` matches the v8 value `b`. /// Asserts that the wasmtime value `a` matches the v8 value `b`.
/// ///
/// For NaN values simply just asserts that they're both NaN. /// For NaN values simply just asserts that they're both NaN.
///
/// See https://webassembly.github.io/spec/js-api/index.html#towebassemblyvalue
/// for how the JS-to-Wasm conversions are done.
fn assert_val_match(a: &Val, b: &v8::Local<'_, v8::Value>, scope: &mut v8::HandleScope<'_>) { fn assert_val_match(a: &Val, b: &v8::Local<'_, v8::Value>, scope: &mut v8::HandleScope<'_>) {
match *a { match *a {
Val::I32(wasmtime) => { Val::I32(wasmtime) => {