Don't be clever about representing non-CoW images (#4691)

This commit fixes a build warning on Rust 1.63 when the `memory-init-cow`
feature is disabled in the `wasmtime-runtime` crate. Some "tricks" were
used prior to have the `MemoryImage` type be an empty `enum {}` but that
wreaks havoc with warnings so this commit instead just makes it a unit
struct and makes all methods panic (as they shouldn't be hit anyway).
This commit is contained in:
Alex Crichton
2022-08-11 13:16:28 -05:00
committed by GitHub
parent c5bc368cfe
commit c1c48b4386
2 changed files with 9 additions and 8 deletions

View File

@@ -35,7 +35,9 @@ impl ModuleMemoryImages {
/// places (e.g. a `Memory`), we define a zero-sized type when memory is
/// not included in the build.
#[derive(Debug)]
pub enum MemoryImageSlot {}
pub struct MemoryImageSlot {
_priv: (),
}
#[allow(dead_code)]
impl MemoryImageSlot {
@@ -48,26 +50,26 @@ impl MemoryImageSlot {
_: usize,
_: Option<&Arc<MemoryImage>>,
) -> Result<Self, InstantiationError> {
match *self {}
unreachable!();
}
pub(crate) fn no_clear_on_drop(&mut self) {
match *self {}
unreachable!();
}
pub(crate) fn clear_and_remain_ready(&mut self) -> Result<()> {
match *self {}
unreachable!();
}
pub(crate) fn has_image(&self) -> bool {
match *self {}
unreachable!();
}
pub(crate) fn is_dirty(&self) -> bool {
match *self {}
unreachable!();
}
pub(crate) fn set_heap_limit(&mut self, _: usize) -> Result<()> {
match *self {}
unreachable!();
}
}