T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix check-rustfmt.sh for macOS (#273)

Browse Source 
There are two cases:

1. It seems that grep on macOS exits as soon as it finds the first match. This makes cargo unhappy and it prints message like "failed printing to stdout: Broken pipe (os error 32)". The solution is to fully consume the output from cargo. I choose to use tee for this task.

2. When in a strict mode, bash complains that $1 is not defined (when it's actually not defined in case of omitting --install). The solution is to apply bash substitution magic: when $1 is undefined or set to null substitute it with empty string.
This commit is contained in:
Sergey Pepyakin
2018-03-18 23:53:02 +03:00
committed by Dan Gohman
parent 9a49bc2ec9
commit c161b0d103
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
check-rustfmt.sh
View File

@@ -22,11 +22,11 @@ set -euo pipefail
# operation, however that doesn't appear to be possible through "cargo fmt"). # operation, however that doesn't appear to be possible through "cargo fmt").
VERS="0.9.0" VERS="0.9.0"
if cargo install --list | grep -q "^rustfmt v$VERS"; then if cargo install --list | tee /dev/null | grep -q "^rustfmt v$VERS"; then
exit 0 exit 0
fi fi
if [ "$1" != "--install" ]; then if [[ ${1:-""} != "--install" ]]; then
echo "********************************************************************" echo "********************************************************************"
echo "* Please install rustfmt v$VERS to verify formatting. *" echo "* Please install rustfmt v$VERS to verify formatting. *"
echo "* If a newer version of rustfmt is available, update this script. *" echo "* If a newer version of rustfmt is available, update this script. *"