cranelift: remove load_complex and store_complex (#3976)

This change removes all variants of `load*_complex` and `store*_complex`
from Cranelift; this is a breaking change to the instructions exposed by
CLIF. The complete list of instructions removed is: `load_complex`,
`store_complex`, `uload8_complex`, `sload8_complex`, `istore8_complex`,
`sload8_complex`, `uload16_complex`, `sload16_complex`,
`istore16_complex`, `uload32_complex`, `sload32_complex`,
`istore32_complex`, `uload8x8_complex`, `sload8x8_complex`,
`sload16x4_complex`, `uload16x4_complex`, `uload32x2_complex`,
`sload32x2_complex`.

The rationale for this removal is that the Cranelift backend now has the
ability to pattern-match multiple upstream additions in order to
calculate the address to access. Previously, this was not possible so
the `*_complex` instructions were needed. Over time, these instructions
have fallen out of use in this repository, making the additional
overhead of maintaining them a chore.

cranelift/codegen/src/isa/s390x/lower.rs

@@ -291,17 +291,11 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>(
         | Opcode::FminPseudo
         | Opcode::FmaxPseudo
         | Opcode::Uload8x8
-        | Opcode::Uload8x8Complex
         | Opcode::Sload8x8
-        | Opcode::Sload8x8Complex
         | Opcode::Uload16x4
-        | Opcode::Uload16x4Complex
         | Opcode::Sload16x4
-        | Opcode::Sload16x4Complex
         | Opcode::Uload32x2
-        | Opcode::Uload32x2Complex
         | Opcode::Sload32x2
-        | Opcode::Sload32x2Complex
         | Opcode::Vconst
         | Opcode::Shuffle
         | Opcode::Vsplit
@@ -333,20 +327,6 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>(
             panic!("Unused opcode should not be encountered.");
         }
 
-        Opcode::LoadComplex
-        | Opcode::Uload8Complex
-        | Opcode::Sload8Complex
-        | Opcode::Uload16Complex
-        | Opcode::Sload16Complex
-        | Opcode::Uload32Complex
-        | Opcode::Sload32Complex
-        | Opcode::StoreComplex
-        | Opcode::Istore8Complex
-        | Opcode::Istore16Complex
-        | Opcode::Istore32Complex => {
-            panic!("Load/store complex opcode should not be encountered.");
-        }
-
         Opcode::Ifcmp
         | Opcode::Ffcmp
         | Opcode::Trapff

cranelift/codegen/src/isa/s390x/lower/isle/generated_code.manifest

@@ -1,4 +1,4 @@
-src/clif.isle 9ea75a6f790b5c03
+src/clif.isle 443b34b797fc8ace
 src/prelude.isle 74d9514ac948e163
 src/isa/s390x/inst.isle d91a16074ab186a8
 src/isa/s390x/lower.isle 1cc5a12adc8c75f9