T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make passes assert their dependencies consistently. (#156)

Browse Source 
* Make passes assert their dependencies consistently.

This avoids ambiguity about whose responsibility it is to run
to compute cfg, domtree, and loop_analysis data.

* Reset the `valid` flag in DominatorTree's `clear()`.

* Remove the redundant assert from DominatorTree::with_function.

* Remove the message strings from obvious asserts.

This avoids having them spill out into multiple lines.

* Refactor calls to `compute` on `Context` objects into helper functions.
This commit is contained in:
Dan Gohman
2017-09-14 14:38:53 -07:00
committed by GitHub
parent 39992014e0
commit bbe056bf9d
15 changed files with 72 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/cretonne/src/licm.rs
View File

@@ -16,9 +16,10 @@ pub fn do_licm(
domtree: &mut DominatorTree,
loop_analysis: &mut LoopAnalysis,
) {
cfg.ensure(func);
domtree.ensure(func, cfg);
loop_analysis.ensure(func, cfg, domtree);
debug_assert!(cfg.is_valid());
debug_assert!(domtree.is_valid());
debug_assert!(loop_analysis.is_valid());
for lp in loop_analysis.loops() {
// For each loop that we want to optimize we determine the set of loop-invariant
// instructions