Remove need for HostRef<Engine> (#762)

This commit removes the need to use `HostRef<Engine>` in the Rust API.
Usage is retained in the C API in one location, but otherwise `Engine`
can always be used directly.

This is the first step of progress on #708 for the `Engine` type.
Changes here include:

* `Engine` is now `Clone`, and is documented as being cheap. It's not
  intended that cloning an engine creates a deep copy.
* `Engine` is now both `Send` and `Sync`, and asserted to be so.
* Usage of `Engine` in APIs no longer requires or uses `HostRef`.
This commit is contained in:
Alex Crichton
2020-01-06 15:17:03 -06:00
committed by GitHub
parent ad7d48479e
commit b9dc38f4e1
18 changed files with 56 additions and 28 deletions

View File

@@ -40,7 +40,7 @@ pub fn instantiate(wasm: &[u8], compilation_strategy: CompilationStrategy) {
let mut config = Config::new();
config.strategy(compilation_strategy);
let engine = HostRef::new(Engine::new(&config));
let engine = Engine::new(&config);
let store = HostRef::new(Store::new(&engine));
let module =
@@ -89,7 +89,7 @@ pub fn make_api_calls(api: crate::generators::api::ApiCalls) {
use crate::generators::api::ApiCall;
let mut config: Option<Config> = None;
let mut engine: Option<HostRef<Engine>> = None;
let mut engine: Option<Engine> = None;
let mut store: Option<HostRef<Store>> = None;
let mut modules: HashMap<usize, HostRef<Module>> = Default::default();
let mut instances: HashMap<usize, HostRef<Instance>> = Default::default();
@@ -107,7 +107,7 @@ pub fn make_api_calls(api: crate::generators::api::ApiCalls) {
ApiCall::EngineNew => {
assert!(engine.is_none());
engine = Some(HostRef::new(Engine::new(config.as_ref().unwrap())));
engine = Some(Engine::new(config.as_ref().unwrap()));
}
ApiCall::StoreNew => {