T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix x86-64 encoding of uextend.i64.i8

Browse Source 
The non-REX encoding of movzbl requires one of the ABCD registers as input.
This commit is contained in:
Philip Craig
2019-04-05 20:40:22 +10:00
committed by Dan Gohman
parent 84fede890c
commit b74b49f7c6
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cranelift/codegen/meta-python/isa/x86/encodings.py
View File

@@ -631,7 +631,7 @@ X86_64.enc(base.uextend.i32.i16, *r.urm_noflags(0x0f, 0xb7))
# movzbq, encoded as movzbl because it's equivalent and shorter # movzbq, encoded as movzbl because it's equivalent and shorter
X86_64.enc(base.uextend.i64.i8, *r.urm_noflags.rex(0x0f, 0xb6)) X86_64.enc(base.uextend.i64.i8, *r.urm_noflags.rex(0x0f, 0xb6))
X86_64.enc(base.uextend.i64.i8, *r.urm_noflags(0x0f, 0xb6)) X86_64.enc(base.uextend.i64.i8, *r.urm_noflags_abcd(0x0f, 0xb6))
# movzwq, encoded as movzwl because it's equivalent and shorter # movzwq, encoded as movzwl because it's equivalent and shorter
X86_64.enc(base.uextend.i64.i16, *r.urm_noflags.rex(0x0f, 0xb7)) X86_64.enc(base.uextend.i64.i16, *r.urm_noflags.rex(0x0f, 0xb7))

12
cranelift/filetests/filetests/isa/x86/shrink.clif
View File

@@ -26,3 +26,15 @@ ebb0(v0: i32 [ %r8 ]):
[-,%r8] v2 = isub v0, v1 ; bin: 41 29 c8 [-,%r8] v2 = isub v0, v1 ; bin: 41 29 c8
return v2 return v2
} }
function %test_not_shrinking_i8() {
ebb0:
[-,%rsi] v1 = iconst.i8 1
; asm: movsbl %sil,%esi
[-,%rsi] v2 = sextend.i32 v1 ; bin: 40 0f be f6
; asm: movzbl %sil,%esi
[-,%rsi] v3 = uextend.i32 v1 ; bin: 40 0f b6 f6
; asm: movzbl %sil,%esi
[-,%rsi] v4 = uextend.i64 v1 ; bin: 40 0f b6 f6
trap user0
}