From b4280d6cd67c2ba09ef07ed23fd8f1e033764a79 Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Sat, 29 Jun 2019 11:21:48 +0200 Subject: [PATCH] Use ManuallyDrop instead of forget --- src/sys/unix/fdentry.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/sys/unix/fdentry.rs b/src/sys/unix/fdentry.rs index a2237161a8..2491b6ed28 100644 --- a/src/sys/unix/fdentry.rs +++ b/src/sys/unix/fdentry.rs @@ -79,10 +79,9 @@ pub unsafe fn determine_type_rights( host::__wasi_errno_t, > { let (ty, rights_base, rights_inheriting) = { - let file = File::from_raw_fd(rawfd); - let ft = file.metadata().unwrap().file_type(); // we just make a `File` here for convenience; we don't want it to close when it drops - std::mem::forget(file); + let file = std::mem::ManuallyDrop::new(File::from_raw_fd(rawfd)); + let ft = file.metadata().unwrap().file_type(); if ft.is_block_device() { ( host::__WASI_FILETYPE_BLOCK_DEVICE,