From b2a3b3402228691a8b0c9cdcdc1d2fb61b2ce088 Mon Sep 17 00:00:00 2001
From: Angus Holder <aholder97@gmail.com>
Date: Wed, 22 Feb 2017 18:07:14 +0000
Subject: [PATCH] Add assertion that the NonZero optimization works on
 Option<Opcode>.

---
 lib/cretonne/src/ir/instructions.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/cretonne/src/ir/instructions.rs b/lib/cretonne/src/ir/instructions.rs
index 216e88b883..839219fc2a 100644
--- a/lib/cretonne/src/ir/instructions.rs
+++ b/lib/cretonne/src/ir/instructions.rs
@@ -736,6 +736,8 @@ mod tests {
 
     #[test]
     fn opcodes() {
+        use std::mem;
+
         let x = Opcode::Iadd;
         let mut y = Opcode::Isub;
 
@@ -753,6 +755,12 @@ mod tests {
         assert_eq!("iadd\0".parse::<Opcode>(), Err("Unknown opcode"));
         assert_eq!("".parse::<Opcode>(), Err("Unknown opcode"));
         assert_eq!("\0".parse::<Opcode>(), Err("Unknown opcode"));
+
+        // Opcode is a single byte, and because Option<Opcode> originally came to 2 bytes, early on
+        // Opcode included a variant NotAnOpcode to avoid the unnecessary bloat. Since then the Rust
+        // compiler has brought in NonZero optimization, meaning that an enum not using the 0 value
+        // can be optional for no size cost. We want to ensure Option<Opcode> remains small.
+        assert_eq!(mem::size_of::<Opcode>(), mem::size_of::<Option<Opcode>>());
     }
 
     #[test]