T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[frontend] Add message for pristine assertion violation

Browse Source 
After we add any instruction to an EBB, we can't add EBB parameters
anymore. There is an assertion in `append_ebb_param` to detect this
error, but the backtrace generated doesn't give any hint what happened.

We add an error message to the assertion so the user can understand what
is wrong.

fixes #1003
This commit is contained in:
Wander Lairson Costa
2019-09-14 20:12:56 -03:00
committed by Benjamin Bouvier
parent 4aef679243
commit a51606bfeb
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cranelift/frontend/src/frontend.rs
View File

@@ -523,7 +523,10 @@ impl FunctionBuilder {
/// **Note:** this function has to be called at the creation of the `Ebb` before adding /// **Note:** this function has to be called at the creation of the `Ebb` before adding
/// instructions to it, otherwise this could interfere with SSA construction. /// instructions to it, otherwise this could interfere with SSA construction.
pub fn append_ebb_param(&mut self, ebb: Ebb, ty: Type) -> Value { pub fn append_ebb_param(&mut self, ebb: Ebb, ty: Type) -> Value {
debug_assert!(self.func_ctx.ebbs[ebb].pristine); debug_assert!(
self.func_ctx.ebbs[ebb].pristine,
"You can't add EBB parameters after adding any instruction"
);
debug_assert_eq!( debug_assert_eq!(
self.func_ctx.ebbs[ebb].user_param_count, self.func_ctx.ebbs[ebb].user_param_count,
self.func.dfg.num_ebb_params(ebb) self.func.dfg.num_ebb_params(ebb)