Add JITBuilder::with_flags constructor (#5751)

This allows custom flags to be set (e.g. `opt-level`) while still
leaving most of of the boilerplate to select the native target to
the `JITBuilder`.
This commit is contained in:
Amanieu d'Antras
2023-02-09 03:49:17 +01:00
committed by GitHub
parent 7c5c7e4b6d
commit a2d356d45e
2 changed files with 31 additions and 2 deletions

View File

@@ -42,8 +42,25 @@ impl JITBuilder {
/// argument, use `cranelift_module::default_libcall_names()`.
pub fn new(
libcall_names: Box<dyn Fn(ir::LibCall) -> String + Send + Sync>,
) -> ModuleResult<Self> {
Self::with_flags(&[], libcall_names)
}
/// Create a new `JITBuilder` with the given flags.
///
/// The `libcall_names` function provides a way to translate `cranelift_codegen`'s `ir::LibCall`
/// enum to symbols. LibCalls are inserted in the IR as part of the legalization for certain
/// floating point instructions, and for stack probes. If you don't know what to use for this
/// argument, use `cranelift_module::default_libcall_names()`.
pub fn with_flags(
flags: &[(&str, &str)],
libcall_names: Box<dyn Fn(ir::LibCall) -> String + Send + Sync>,
) -> ModuleResult<Self> {
let mut flag_builder = settings::builder();
for (name, value) in flags {
flag_builder.set(name, value)?;
}
// On at least AArch64, "colocated" calls use shorter-range relocations,
// which might not reach all definitions; we can't handle that here, so
// we require long-range relocation types.
@@ -59,8 +76,8 @@ impl JITBuilder {
/// Create a new `JITBuilder` with an arbitrary target. This is mainly
/// useful for testing.
///
/// To create a `JITBuilder` for native use, use the `new` constructor
/// instead.
/// To create a `JITBuilder` for native use, use the `new` or `with_flags`
/// constructors instead.
///
/// The `libcall_names` function provides a way to translate `cranelift_codegen`'s `ir::LibCall`
/// enum to symbols. LibCalls are inserted in the IR as part of the legalization for certain