T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not loop with nfds=0, timeout=-1

Browse Source
This commit is contained in:
Marcin Mielniczuk
2019-12-15 19:27:12 +01:00
parent 5cd3e9904f
commit a2b556f1b0
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
crates/wasi-common/src/sys/windows/hostcalls_impl/misc.rs
View File

@@ -125,18 +125,13 @@ pub(crate) fn poll_oneoff(
// With no events to listen, poll_oneoff just becomes a sleep. // With no events to listen, poll_oneoff just becomes a sleep.
if fd_events.is_empty() { if fd_events.is_empty() {
match timeout_duration { match timeout_duration {
Some(t) => { Some(t) => thread::sleep(t),
thread::sleep(t);
return Ok(());
}
None => {
// `poll` invoked with nfds = 0, timeout = -1 appears to be an infinite sleep // `poll` invoked with nfds = 0, timeout = -1 appears to be an infinite sleep
// The thread is not guanteed to remain parked forever, so we need to loop // Even though the thread is not guanteed to remain parked forever, `poll(2)`
loop { // mentions that spurious readiness notifications may occur, so it's probably fine
thread::park(); None => thread::park(),
}
}
} }
return Ok(());
} }
// Currently WASI file support is only (a) regular files (b) directories (c) symlinks on Windows, // Currently WASI file support is only (a) regular files (b) directories (c) symlinks on Windows,