wasi-common: deprecate fd_allocate (#6217)

* wasi-common: remove allocate from WasiFile trait, always fail with NOTSUP

This operation from cloudabi is linux-specific, isn't even
supported across all linux filesystems, and has no support on macos
or windows. Rather than ship spotty support, it has been removed
from preview 2, and we are no longer supporting it in preview 1 as
well.

The preview 1 implementation will still check if fd is a file, and has
rights, just to reject those cases with the errors expected.

* wasi-tests: expect fd_allocate to always fail now.

rewrite the file_allocate test to just check for failure.

remove use of fd_allocate from fd_advise test, and remove test
configuration setting used for excluding use of fd_allocate on macos and
windows.
This commit is contained in:
Pat Hickey
2023-04-17 14:35:28 -07:00
committed by GitHub
parent 7ebff82861
commit 9ee613a0b7
8 changed files with 26 additions and 55 deletions

View File

@@ -84,10 +84,6 @@ impl WasiFile for File {
self.0.advise(offset, len, convert_advice(advice))?;
Ok(())
}
async fn allocate(&self, offset: u64, len: u64) -> Result<(), Error> {
self.0.allocate(offset, len)?;
Ok(())
}
async fn set_times(
&self,
atime: Option<wasi_common::SystemTimeSpec>,