wasi-common: deprecate fd_allocate (#6217)
* wasi-common: remove allocate from WasiFile trait, always fail with NOTSUP This operation from cloudabi is linux-specific, isn't even supported across all linux filesystems, and has no support on macos or windows. Rather than ship spotty support, it has been removed from preview 2, and we are no longer supporting it in preview 1 as well. The preview 1 implementation will still check if fd is a file, and has rights, just to reject those cases with the errors expected. * wasi-tests: expect fd_allocate to always fail now. rewrite the file_allocate test to just check for failure. remove use of fd_allocate from fd_advise test, and remove test configuration setting used for excluding use of fd_allocate on macos and windows.
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
pub struct TestConfig {
|
||||
errno_mode: ErrnoMode,
|
||||
no_dangling_filesystem: bool,
|
||||
no_fd_allocate: bool,
|
||||
no_rename_dir_to_empty_dir: bool,
|
||||
no_fdflags_sync_support: bool,
|
||||
}
|
||||
@@ -25,13 +24,11 @@ impl TestConfig {
|
||||
ErrnoMode::Permissive
|
||||
};
|
||||
let no_dangling_filesystem = std::env::var("NO_DANGLING_FILESYSTEM").is_ok();
|
||||
let no_fd_allocate = std::env::var("NO_FD_ALLOCATE").is_ok();
|
||||
let no_rename_dir_to_empty_dir = std::env::var("NO_RENAME_DIR_TO_EMPTY_DIR").is_ok();
|
||||
let no_fdflags_sync_support = std::env::var("NO_FDFLAGS_SYNC_SUPPORT").is_ok();
|
||||
TestConfig {
|
||||
errno_mode,
|
||||
no_dangling_filesystem,
|
||||
no_fd_allocate,
|
||||
no_rename_dir_to_empty_dir,
|
||||
no_fdflags_sync_support,
|
||||
}
|
||||
@@ -57,9 +54,6 @@ impl TestConfig {
|
||||
pub fn support_dangling_filesystem(&self) -> bool {
|
||||
!self.no_dangling_filesystem
|
||||
}
|
||||
pub fn support_fd_allocate(&self) -> bool {
|
||||
!self.no_fd_allocate
|
||||
}
|
||||
pub fn support_rename_dir_to_empty_dir(&self) -> bool {
|
||||
!self.no_rename_dir_to_empty_dir
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user