T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use unsafe to mark reopen_with_fdflags as having special safety features

Browse Source
This commit is contained in:
Pat Hickey
2021-01-21 18:08:15 -08:00
parent 69b7352332
commit 9e0d295f8c
5 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/wasi-c2/cap-std-sync/src/file.rs
View File

@@ -38,7 +38,7 @@ impl WasiFile for File {
// XXX get_fdflags is not implemented but lets lie rather than panic:
Ok(FdFlags::empty())
}
fn reopen_with_fdflags(&self, _fdflags: FdFlags) -> Result<Box<dyn WasiFile>, Error> {
unsafe fn reopen_with_fdflags(&self, _fdflags: FdFlags) -> Result<Box<dyn WasiFile>, Error> {
todo!("reopen_with_fdflags is not implemented")
}
fn get_filestat(&self) -> Result<Filestat, Error> {

7
crates/wasi-c2/cap-std-sync/src/stdio.rs
View File

@@ -39,7 +39,7 @@ impl WasiFile for Stdin {
// XXX get_fdflags is not implemented but lets lie rather than panic:
Ok(FdFlags::empty())
}
fn reopen_with_fdflags(&self, _fdflags: FdFlags) -> Result<Box<dyn WasiFile>, Error> {
unsafe fn reopen_with_fdflags(&self, _fdflags: FdFlags) -> Result<Box<dyn WasiFile>, Error> {
Err(Error::Badf)
}
fn get_filestat(&self) -> Result<Filestat, Error> {
@@ -128,7 +128,10 @@ macro_rules! wasi_file_write_impl {
// XXX get_fdflags is not implemented but lets lie rather than panic:
Ok(FdFlags::empty())
}
fn reopen_with_fdflags(&self, _fdflags: FdFlags) -> Result<Box<dyn WasiFile>, Error> {
unsafe fn reopen_with_fdflags(
&self,
_fdflags: FdFlags,
) -> Result<Box<dyn WasiFile>, Error> {
Err(Error::Badf)
}
fn get_filestat(&self) -> Result<Filestat, Error> {