T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cranelift/reader/src/parser.rs: fn parse_inst_resuts: produce the results as a

Browse Source 
SmallVec<[Value; 1]>, not as a Vec<Value>.  This isn't a useful change for any
non-developer use of Cranelift, but it does significantly reduce the amount of
allocation "noise" seen when tuning the new backend pipeline as driven by
clif-util reading .clif files.  In one case the number of malloc calls
declined by about 20% with this change.
This commit is contained in:
Julian Seward
2020-05-11 11:09:40 +02:00
committed by julian-seward1
parent ee2f861fdd
commit 94190d5724
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cranelift/reader/src/parser.rs
View File

@@ -23,6 +23,7 @@ use cranelift_codegen::ir::{
use cranelift_codegen::isa::{self, CallConv, Encoding, RegUnit, TargetIsa};
use cranelift_codegen::packed_option::ReservedValue;
use cranelift_codegen::{settings, timing};
use smallvec::SmallVec;
use std::mem;
use std::str::FromStr;
use std::{u16, u32};
@@ -2223,9 +2224,9 @@ impl<'a> Parser<'a> {
//
// inst-results ::= Value(v) { "," Value(v) }
//
fn parse_inst_results(&mut self) -> ParseResult<Vec<Value>> {
fn parse_inst_results(&mut self) -> ParseResult<SmallVec<[Value; 1]>> {
// Result value numbers.
let mut results = Vec::new();
let mut results = SmallVec::new();
// instruction ::= * [inst-results "="] Opcode(opc) ["." Type] ...
// inst-results ::= * Value(v) { "," Value(v) }