T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

windows/x64 call convention: only use XMM0 for float return values (#691)

Browse Source
This commit is contained in:
Steffen Butzer
2019-03-09 21:27:55 +01:00
committed by Benjamin Bouvier
parent 00cfe62380
commit 92b3987e54
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cranelift/codegen/src/isa/x86/abi.rs
View File

@@ -161,13 +161,14 @@ pub fn legalize_signature(sig: &mut ir::Signature, triple: &Triple, _current: bo
legalize_args(&mut sig.params, &mut args); legalize_args(&mut sig.params, &mut args);
let regs = if sig.call_conv == CallConv::WindowsFastcall { let (regs, fpr_limit) = if sig.call_conv == CallConv::WindowsFastcall {
&RET_GPRS_WIN_FASTCALL_X64[..] // windows-x64 calling convention only uses XMM0 or RAX for return values
(&RET_GPRS_WIN_FASTCALL_X64[..], 1)
} else { } else {
&RET_GPRS[..] (&RET_GPRS[..], 2)
}; };
let mut rets = Args::new(bits, regs, 2, sig.call_conv); let mut rets = Args::new(bits, regs, fpr_limit, sig.call_conv);
legalize_args(&mut sig.returns, &mut rets); legalize_args(&mut sig.returns, &mut rets);
} }

6
cranelift/filetests/filetests/isa/x86/windows_fastcall_x64.clif
View File

@@ -37,3 +37,9 @@ ebb0(v0: i64, v1: f64, v2: i64, v3: f32):
return return
} }
; check: function %mixed_int_float(i64 [%rcx], f64 [%xmm1], i64 [%r8], f32 [%xmm3], i64 fp [%rbp]) -> i64 fp [%rbp] windows_fastcall { ; check: function %mixed_int_float(i64 [%rcx], f64 [%xmm1], i64 [%r8], f32 [%xmm3], i64 fp [%rbp]) -> i64 fp [%rbp] windows_fastcall {
function %ret_val_float(f32, f64, i64, i64) -> f64 windows_fastcall {
ebb0(v0: f32, v1: f64, v2: i64, v3: i64):
return v1
}
; check: function %ret_val_float(f32 [%xmm0], f64 [%xmm1], i64 [%r8], i64 [%r9], i64 fp [%rbp]) -> f64 [%xmm0], i64 fp [%rbp] windows_fastcall {