T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(wasi)!: make most WasiFile methods take &mut self (#3901)

Browse Source 
1. This makes it easier for implementors to deal with internal APIs.
2. This matches the signatures of the WASI Snapshot traits.

Although it is likely true that these methods would have to become
immutable in order to implement threading efficiently, threading will
impact a large number of existing traits. So this change is practical
for now with an already-unavoidable change required for threading.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
This commit is contained in:
Nathaniel McCallum
2022-03-09 18:22:42 -05:00
committed by GitHub
parent 44a435a43a
commit 8b48ce7fb7
10 changed files with 138 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
crates/wasi-common/src/ctx.rs
View File

@@ -70,22 +70,22 @@ impl WasiCtx {
Ok(())
}
pub fn set_stdin(&mut self, f: Box<dyn WasiFile>) {
let rights = Self::stdio_rights(&*f);
pub fn set_stdin(&mut self, mut f: Box<dyn WasiFile>) {
let rights = Self::stdio_rights(&mut *f);
self.insert_file(0, f, rights);
}
pub fn set_stdout(&mut self, f: Box<dyn WasiFile>) {
let rights = Self::stdio_rights(&*f);
pub fn set_stdout(&mut self, mut f: Box<dyn WasiFile>) {
let rights = Self::stdio_rights(&mut *f);
self.insert_file(1, f, rights);
}
pub fn set_stderr(&mut self, f: Box<dyn WasiFile>) {
let rights = Self::stdio_rights(&*f);
pub fn set_stderr(&mut self, mut f: Box<dyn WasiFile>) {
let rights = Self::stdio_rights(&mut *f);
self.insert_file(2, f, rights);
}
fn stdio_rights(f: &dyn WasiFile) -> FileCaps {
fn stdio_rights(f: &mut dyn WasiFile) -> FileCaps {
let mut rights = FileCaps::all();
// If `f` is a tty, restrict the `tell` and `seek` capabilities, so